search

ESCOMP / CAM-SIMA

Community Atmosphere Model - System for Integrated Modeling of the Atmosphere
3 stars 11 forks source link

Update NUOPC cap and externals to match CAM #262

Closed nusbaume closed 2 months ago

nusbaume commented 2 months ago

This PR updates the NUOPC cap to match the version used in cam6_3_160, as well as the externals. Additional clean-up was also performed, including the removal of the now deprecated MCT cap.

Resolves #146

Tests run:

Ran Kessler and Held-Suarez snapshot comparison runs on Derecho with GNU.

Ran official regression tests (test_driver.sh) with both GNU and Intel on Derecho.

nusbaume commented 2 months ago

@cacraigucar @peverwhee when reviewing the src/cpl/nuopc/* files I would avoid trying to review them on Github, and instead just diff them against the same files that are currently in the CAM development branch to see what the differences currently are between SIMA and CAM. Of course if you have any questions or concerns with those files just let me know. Thanks!

nusbaume commented 2 months ago

@peverwhee Just FYI I also did some use statement re-arrangement to try and better match the Fortran coding standards for CAM-SIMA. I didn't completely finish the effort though, mostly to avoid making comparisons with the original CAM code overly difficult.