ESCOMP / CAM-SIMA

Community Atmosphere Model - System for Integrated Modeling of the Atmosphere
3 stars 11 forks source link

Simplify snapshot checking reporting and functionality #269

Closed nusbaume closed 1 month ago

nusbaume commented 1 month ago

This PR ensures that snapshot checks (e.g. ncdata_check) are only run during actual model run steps (not initialize or finalize steps), and that there is no offset between the model timestep and the input or check file time.

This PR also adds a new current_timestep_number registry variable which is updated every time the model time step advances, as well as a new log print statement that indicates which model timestep CAM-SIMA is currently on.

Fixes #268

Tests run:

Ran a physics testbed configuration with both Kessler and Held-Suarez physics for both a single timestep and for multiple timesteps (no differences found for any of the tests).

Also ran the official regression build tests on derecho for both GNU and Intel.