ESCOMP / CAM-SIMA

Community Atmosphere Model - System for Integrated Modeling of the Atmosphere
3 stars 11 forks source link

Integration of CCPP-ized TJ2016 implementation #271

Closed mwaxmonsky closed 1 week ago

mwaxmonsky commented 1 month ago

Updates atmospheric_physics to the latest tag bringing in TJ2016 capability and additional changes needed in support of TJ2016.

Describe any changes made to build system: N/A

Describe any changes made to the namelist: N/A

List any changes to the defaults for the boundary datasets: N/A

Describe any substantial timing or memory changes: N/A

Code reviewed by: nusbaume, peverwhee

List all existing files that have been modified, old files eliminated, new files added and describe the changes:

M Externals_CAM.cfg

M src/control/cam_comp.F90

M src/data/physconst.meta

M src/data/registry.xml A src/dynamics/utils/hycoef.meta

M src/dynamics/utils/hycoef.F90

A tools/generate_input_to_stdnames_update.py

M tools/inputnames_to_stdnames.py

M tools/stdnames_to_inputnames_dictionary.xml

M cime_config/testdefs/testlist_cam.xml D cime_config/testdefs/testmods_dirs/cam/outfrq_held_suarez_izumi_nooutput/shell_commands D cime_config/testdefs/testmods_dirs/cam/outfrq_held_suarez_izumi_nooutput/user_nl_cam D cime_config/testdefs/testmods_dirs/cam/outfrq_kessler_izumi_nooutput/shell_commands D cime_config/testdefs/testmods_dirs/cam/outfrq_kessler_izumi_nooutput/user_nl_cam A cime_config/testdefs/testmods_dirs/cam/outfrq_tj2016_derecho_nooutput/shell_commands A cime_config/testdefs/testmods_dirs/cam/outfrq_tj2016_derecho_nooutput/user_nl_cam

If there were any failures reported from running test_driver.sh on any test platform, and checkin with these failures has been OK'd by the gatekeeper, then copy the lines from the td.*.status files for the failed tests to the appropriate machine below. All failed tests must be justified.

derecho/intel/aux_cam derecho/gnu/aux_cam

Summarize any changes to answers, i.e.,

mwaxmonsky commented 1 week ago

@peverwhee @nusbaume I fixed the merge conflicts and brought in the git-fleximod updates but if either of you had a sec, could you double check I didn't break anything with the fleximod update? Everything works on my end but I just want to make sure the git update works as expected on the user side.

peverwhee commented 1 week ago

@mwaxmonsky I ran a clean check-out of CAM-SIMA with your updates and git-fleximod worked well. I did run into this bug - https://github.com/ESCOMP/CAM-SIMA/pull/280 (introduced by me), but I vote for merging this PR!