Fix physconst units - Githubissues

ESCOMP / CAM-SIMA

Community Atmosphere Model - System for Integrated Modeling of the Atmosphere

4 stars 12 forks source link

Fix physconst units #283

Open peverwhee opened 3 months ago

peverwhee commented 3 months ago

What happened?

A couple of physconst units are wrong in src/data/physconst.meta:

avogadro_number should be molecules kmol-1
boltzmann_constant should be J K-1 molecule-1

What are the steps to reproduce the bug?

Not reproducible. No schemes are currently using either erroneously unit-ed variable.

What CAM-SIMA hash were you using?

8ac3838

What machine were you running CAM-SIMA on?

CISL machine (e.g. cheyenne)

What compiler were you using?

Intel

Path to a case directory, if applicable

No response

Will you be addressing this bug yourself?

Any Software Engineer can do this

Extra info

Just need to update the units in .meta; the comments in .F90 are correct.