ESCOMP / CAM-SIMA

Community Atmosphere Model - System for Integrated Modeling of the Atmosphere
4 stars 12 forks source link

Remove utils/interpolate_data #307

Open jimmielin opened 1 month ago

jimmielin commented 1 month ago

Issue Type

Code Clean-up

Issue Description

src/utils/interpolate_data.F90 was brought in entirely from CAM to support reading the tropopause climatology file.

During the review of tropopause_find CCPP-ization, @nusbaume wrote:

It's unclear to me what the long-term state of things like lat/lon interpolation will be in CAM-SIMA (e.g. we might end up using external libraries like ESMF to do all the work for us). Thus I decided to skip reviewing this particular Fortran module. That being said, I don't want to us to completely forget about it either (it could certainly use some modifications if we do decide to stick with it long-term). So when you get the chance could you create an issue in CAM-SIMA reminding us to either clean-it-up or replace it at some point? Thanks!

This issue reminds us of the eventual clean-up needed for this module or replacement with a ESMF approach.

Will this change answers?

No

Will you be implementing this yourself?

Any Software Engineer can do this

jimmielin commented 1 month ago

may also be related to #265