search

ESCOMP / CCPPStandardNames

Repository for community-accepted CCPP Standard Names and search tools
Other
3 stars 16 forks source link

fix typos #11

Closed cacraigucar closed 10 months ago

cacraigucar commented 3 years ago

x_wind: Horizontal wind in a direction perdendicular to y_wind

y_wind: Horizontal wind in a direction perdendicular to x_wind

"Perpendicular" is mistyped

Units for avogadro are "molecule mole-1", but will not match the current CAM definition (no change needed here)

nusbaume commented 3 years ago

Just double-checking that you meant Perpendicular?

cacraigucar commented 3 years ago

Just double-checking that you meant Perpendicular?

Yup - even my typo correction has a typo! I was concentrating so hard on the "d" to "p". The good news is that I typed it right when I put it into CAMDEN!

cacraigucar commented 3 years ago

constituent_mixing_ratio: Constituent mixing ratio real(kind=kind_phys): units = kg/kg moist or dry air depending on type

Units should be "kg kg-1"

cacraigucar commented 3 years ago

cell_weight units should be "1"

cacraigucar commented 3 years ago

"pressure_dependent_XXX" needs to become "composition_dependent_XXX"

nusbaume commented 1 year ago

Also adding a note here that gravitational_acceleration should probably be moved from coordinates to constants.

climbfuji commented 1 year ago

gravitational_acceleration is not a constant. gravitational_constant is, but gravitational_acceleration depends on the distance from the center of the Earth.

nusbaume commented 1 year ago

Yeah we kept going back and forth on this, because although you are correct that gravity varies as a function of distance from the planet's center, our low and mid-top models treat it as a strict constant of ~9.81 m s-2.

Regardless, I am happy to move it to a different section in the standard names dictionary to indicate that it should change with height, at least in the real world. Would state_variables work?

I mostly don't want it in coordinates because it doesn't seem directly related to the geospatial grid itself. In other words if you output a physical quantity X to a NetCDF file it would seem weird (to me at least) to have its dimensions be X(lat, lon, gravity). That being said, if you have a counter example then I am happy to just keep it where it is.

nusbaume commented 1 year ago

Just leaving a note here that the discussion on gravitational_acceleration has been moved to issue #39.