search

ESCOMP / CCPPStandardNames

Repository for community-accepted CCPP Standard Names and search tools
Other
3 stars 16 forks source link

Add JEDI UFO CF-compliant names #28

Closed svahl991 closed 1 year ago

svahl991 commented 1 year ago

The JCSDA JEDI software project has decided to adopt the CCPP naming standard to use for model variables in its generic code. This PR adds some variable names to CCPP that are already CF-standards and are in use in JEDI.

This is my first attempt at a PR for this repository, so apologies if I haven't done it quite right. I'm happy to modify.

svahl991 commented 1 year ago

Apologies if I accidentally removed @ligiabernardet as a reviewer on this PR. I'm not sure how that happened. I don't appear to have the ability to re-add.

climbfuji commented 1 year ago

I added her back in. I'll review later today.

dudhia commented 1 year ago

The distinction is needed because some models refer all species to dry air.

On Mon, Jan 30, 2023 at 1:55 PM Benjamin Johnson @.***> wrote:

@.**** commented on this pull request.

In StandardNamesRules.rst https://github.com/ESCOMP/CCPPStandardNames/pull/28#discussion_r1091141641 :

@@ -68,6 +68,10 @@ CCPP Standard Name Rules

. Volume mixing ratios should be qualified as volume_mixing_ratio.

+#. By default, mole_fraction_of_X_in_Y refers to the total amount of Y. So, for example,

I don't know what the general consensus is, but generally mixing ratios are most useful / interesting when dealing with moist air, with the noted exception of water vapor mixing ratio, which is universally applied to dry air.

Water vapor mixing ratio with respect to moist air is defined as "specific humidity", and they differ by as much as a few percent in the Earth's atmosphere.

— Reply to this email directly, view it on GitHub https://github.com/ESCOMP/CCPPStandardNames/pull/28#discussion_r1091141641, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEIZ77E4LWFWO6AG6OD2TYTWVATDPANCNFSM6AAAAAATTPIR44 . You are receiving this because you commented.Message ID: @.***>

climbfuji commented 1 year ago

I re-requested reviews from reviewers who had comments earlier.

climbfuji commented 1 year ago

We have four approvals, therefore I am going to merge this and not let it drag on for longer.