search

ESCOMP / CCPPStandardNames

Repository for community-accepted CCPP Standard Names and search tools
Other
3 stars 16 forks source link

Fix bugs in python table writing and checking scripts #32

Closed nusbaume closed 1 year ago

nusbaume commented 1 year ago

This PR modifies the xml_tools library to allow the use of python 3.7+ when using write_standard_name_table.py. Also fixed the use of the --overwrite flag in check_xml_unique.py.

Fixes #30 Fixes #31

Tests run:

Ran tests with check_xml_unique.py and check_xml_unique.py --overwrite where duplicate variables were added to both the same section and to different sections of standard_names.xml, to make sure the script worked as expected.

Also ran write_standard_name_table.py on a modified standard_names.xml file to make sure the Markdown file was created successfully. This was done with python 3.9.4, 3.10.8, and 2.7.17 to try and test that the script works with multiple versions, including versions newer than 3.6.

Finally, I again wasn't sure who to add as reviewers, so please feel free to expand or modify the reviewer list if need be.

nusbaume commented 1 year ago

@mkavulich I sent you an invite to join this repo in order to add you as a reviewer. Of course if you would prefer to not review this PR (or generally don't want to review PRs in this repo) then just let me know. Thanks!