search

ESCOMP / CCPPStandardNames

Repository for community-accepted CCPP Standard Names and search tools
Other
3 stars 16 forks source link

New sub-section and standard names for land surface variables #60

Closed SamanthaPullen closed 2 months ago

SamanthaPullen commented 3 months ago

This PR addresses Issue #59

This PR adds some variable names to the CCPP Standard Names for land surface variables, in preparation for Met Office work on land surface DA with JEDI. I think it makes sense to add a new sub-section for these surface variables. I have added a subsection land_surface, but it could be a wider scope sub-section covering all surface (i.e. land, sea, sea-ice). Please advise :)

I have added the following land surface variable names, in alphabetical order (which would be nice to see elsewhere in the CCPP Standard Names list, for ease of reference):

  1. land_ice_area_fraction
  2. mass_content_of_water_in_top_soil_layer
  3. surface_snow_density
  4. urban_area_fraction
  5. volume_fraction_of_liquid_water_in_soil_at_critical_point
  6. volume_fraction_of_liquid_water_in_soil_at_saturation
  7. volume_fraction_of_liquid_water_in_soil_at_wilting_point

I have used CF Standard Names (cfconventions.org) where possible, and where nothing suitable exists I have based the proposed CCPP name on the CCPP or CF name of a related or similar variable.

Opened as a draft PR for now to allow coordination between Met Office and JCSDA before submitting for review. Comments welcome in the meantime!

BenjaminRuston commented 3 months ago

thanks @SamanthaPullen ,,,, I'm not part of this repository but @svahl991 wanted to make sure the JCSDA OBS team was also aware.

should tag @ClaraDraper-NOAA as well but may need to send her this link in an email

SamanthaPullen commented 3 months ago

These additions have been discussed with @ClaraDraper-NOAA and she has confirmed that she is happy with them.

ClaraDraper-NOAA commented 3 months ago

These additions have been discussed with @ClaraDraper-NOAA and she has confirmed that she is happy with them.

My apologies, I responded only to the email. These names are fine by me. Thanks for getting this ready @SamanthaPullen

SamanthaPullen commented 3 months ago

There is some associated discussion on the naming conventions and precise definitions of variables for area fractions in #57. This could have implications for the variable names land_ice_area_fraction and urban_area_fraction in this PR

SamanthaPullen commented 3 months ago

I have switched this PR to draft given the related discussion in #57. Will update names for land_ice_area_fraction and urban_area_fraction by appending _of_cell_area after the Easter Holiday and re-open for review

SamanthaPullen commented 3 months ago

@mkavulich @ss421 @svahl991 Following discussion at #57 and for consistency with the naming convention for sea ice fraction variables proposed there, I have modified the following land surface variable names:

modified to:

Now ready for review again - @nusbaume are you happy with this update?

nusbaume commented 2 months ago

@SamanthaPullen Thanks for double-checking with me! Yes those changes look fine on my end, so my approval still holds.

SamanthaPullen commented 2 months ago

@nusbaume , @mkavulich, could this PR be merged please? It has had 2 approvals, but strangely only 1 of them is showing in the panel below

climbfuji commented 2 months ago

@SamanthaPullen I'll ping folks directly to make sure this PR gets reviewed promptly. Sorry for the delay.

SamanthaPullen commented 2 months ago

@mkavulich thank you:)

grantfirl commented 2 months ago

Late to the party, but looks fine to me.