Update Standard Name Rules table for dimensionless units, change variables improperly using "1" to "fraction"

ESCOMP / CCPPStandardNames

Repository for community-accepted CCPP Standard Names and search tools

Other

3 stars 16 forks source link

Update Standard Name Rules table for dimensionless units, change variables improperly using "1" to "fraction" #62

Closed mkavulich closed 2 months ago

mkavulich commented 3 months ago

Related to Issue #26 and discussion therein, this PR updates the Standard Name Rules table for dimensionless units, removing some ambiguity in wording, separating out "frac" from "percent" entries (since fractions and percentages are different things, and can theoretically be converted) and clarifying when "1" should be used. In addition, several standard names that reference fractions are updated to appropriately use "frac" rather than "1".

climbfuji commented 3 months ago

Why can we not spell out fraction? We also spell out percent. The 8-character limit in F77 is history!

mkavulich commented 3 months ago

@climbfuji I'm just going off the existing conventions; all the schemes in ccpp-physics currently use frac. But if we're okay with committing to that change then I'm all for using fraction.

nusbaume commented 3 months ago

I'm personally fine with either frac or fraction, just as long as we aren't using both of them together. I also agree that fraction is certainly less ambiguous (but would require more effort on this particular PR).

climbfuji commented 3 months ago

If it's not too much work, can you change all frac to fraction please?

mkavulich commented 2 months ago

@nusbaume @climbfuji I have made the suggested changes