search

ESCOMP / CDEPS

Community Data Models for Earth Prediction Systems
https://escomp.github.io/CDEPS/versions/master/html/index.html
20 stars 45 forks source link

Add a stream for ZBOT for GSWP3 forcing data #162

Open ekluzek opened 2 years ago

ekluzek commented 2 years ago

Rather than having ZBOT hardcoded in datm we want to have it read from a file. The file will only have one latitude/longitude and time-sample. Hence, most of this will just be adding this to the streams mechanism for GSWP3.

Note, that the current code doesn't read in ZBOT, like it should, it only overrides it if it isn't read (which it always isn't) and then datm_datamode_clmncep_mod.F90 has this line...

       !--- bottom layer height ---
       if (.not. associated(strm_z)) Sa_z(n) = 30.0_r8

It needs the following to be added before that...

    call shr_strdata_get_stream_pointer( sdat, 'Sa_z'        , strm_z  , rc)
    if (ChkErr(rc,__LINE__,u_FILE_u)) return

And then a fixed stream file added to the stream_definition.xml file for CLMGSWP3v1.Z, to handle Sa_z. It'll be a little simpler than the other blocks since it won't need to handle differing years.

ekluzek commented 2 years ago

This corresponds to the CTSM issue: https://github.com/ESCOMP/CTSM/issues/1760

wwieder commented 2 years ago

Just a note that this bug influences NEON or other tower simulations, where zbot is not being read in off input data. Just pinging other's who may run single point tower sites with nuopc. (it's not an issue with mct runs) @negin513 @danicalombardozzi @adrifoster @swensosc @olyson

swensosc commented 2 years ago

For the global files, it can also be a scalar. I discourage adding a gridded field for what will be a time-invariant, globally uniform value due to limited storage space

On Thu, May 19, 2022 at 10:21 AM will wieder @.***> wrote:

Just a note that this bug influences NEON or other tower simulations, where zbot is not being read in off input data. Just pinging other's who may run single point tower sites with nuopc. (it's not an issue with mct runs) @negin513 https://github.com/negin513 @danicalombardozzi https://github.com/danicalombardozzi @adrifoster https://github.com/adrifoster @swensosc https://github.com/swensosc @olyson https://github.com/olyson

— Reply to this email directly, view it on GitHub https://github.com/ESCOMP/CDEPS/issues/162#issuecomment-1131925928, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGRN57ACJKVDSQ7YFQGM67TVKZS7FANCNFSM5WJ5RHHA . You are receiving this because you were mentioned.Message ID: @.***>