search

ESCOMP / CDEPS

Community Data Models for Earth Prediction Systems
https://escomp.github.io/CDEPS/versions/master/html/index.html
18 stars 39 forks source link

SSTICE_DATA_FILENAME for "2000" cases changed after switching to CDEPS #255

Closed adamrher closed 5 months ago

adamrher commented 7 months ago

Ran two F2000dev cases, one with cam6_3_058 and one with cam6_3_132. Diff'ing the env_run.xml file in the case directories:

<     <entry id="SSTICE_DATA_FILENAME" value="$DIN_LOC_ROOT/atm/cam/sst/sst_HadOIBl_bc_1x1_2000climo_c180511.nc">
---
>     <entry id="SSTICE_DATA_FILENAME" value="$DIN_LOC_ROOT/atm/cam/sst/sst_HadOIBl_bc_1x1_clim_c101029.nc">

Somewhere between cam6_3_058 and cam6_3_132, the sstice file was switched to the older c101029 file. These two files are very similar, but with up to 0.5 K differences in SST. I put an ncdiff of the two files here: /glade/scratch/aherring/restart/sstdiff.nc.

Opening this issue to understand whether this was an oversight or intentional. I suspect that the newer file is more appropriate for F2000dev/F2000climo cases as these compsets were introduced during the cam6/cam7 dev cycles.

I suspect this was an oversight of switching the SSTICE_DATA_FILENAME settings from cam (cime_config/config_compsets.xml) to cdeps, which I think occurred in between these tags. I can't figure out exactly where this is set in cdeps b/c I get two hits when I search for the sstice file:

Directory: /glade/u/home/aherring/src/cam6_3_132
1000 /glade/u/home/aherring> grep -r "sst_HadOIBl_bc_1x1_clim_c101029.nc" *
components/cpl7/components/data_comps_mct/docn/cime_config/config_component.xml:    <default_value>$DIN_LOC_ROOT/atm/cam/sst/sst_HadOIBl_bc_1x1_clim_c101029.nc</default_value>
components/cdeps/docn/cime_config/config_component.xml:    <default_value>$DIN_LOC_ROOT/atm/cam/sst/sst_HadOIBl_bc_1x1_clim_c101029.nc</default_value>

[edit - I see the cpl7 directory has 'mct' in it, so I guess it's the cdeps path where this is being set.]

@cecilehannay @islasimpson

jedwards4b commented 7 months ago

I am happy to change this in cdeps. Looking at the timelines the CDEPS code was copied from mct on 06-12-2020 and the mct was updated on 12-16-2020 so it's likely that the CDEPS was not yet widely used and didn't get updated.

jedwards4b commented 7 months ago

But I don't see file sst_HadOIBl_bc_1x1_2000climo_c180511.nc anywhere in the source tree. Can you tell me how it's getting set? I could change just this one file but want to understand if there is a pattern and there are more files that should be newer than what we are using.

adamrher commented 7 months ago

sst_HadOIBl_bc_1x1_2000climo_c180511.nc gets set in cam/cime_config/config_compsets.xml in older tags. In my local sandbox: /glade/u/home/aherring/src/cam6_3_058/cime_config/config_compsets.xml

mvertens commented 7 months ago

@adamrher - SST data files should not be set in CAM - they should be set in CDEPS in the docn cime_config. If older versions had this set in CAM I believe this is a mistake.

jedwards4b commented 7 months ago

@mvertens I believe that the older tags were from prior to moving SST's to docn.