search

ESCOMP / CISM-wrapper

Community Ice Sheet Model wrapper for CESM
http://www.cesm.ucar.edu/models/cesm2.0/land-ice/
Other
3 stars 16 forks source link

Improve stability #16

Closed billsacks closed 6 years ago

billsacks commented 6 years ago

@whlipscomb can you please double-check the changes I made here?

whlipscomb commented 6 years ago

@billsacks, These fixes look good to me. Thanks!

When the changes are checked in, I'd like to run a 1000-year TG test out of the box as a sanity check, just to make sure we haven't missed something.

billsacks commented 6 years ago

@whlipscomb Sorry for the delays here: I've been juggling a few things today. I haven't gotten a chance to bring these changes to master yet, but can you go ahead and start the TG test from this branch? From your cism-wrapper clone, do:

git fetch origin
git checkout improve_stability
./manage_externals/checkout_externals
whlipscomb commented 6 years ago

@billsacks: Thanks, I'll work on this now.

I get an error at the checkout externals step. Can you decipher the following?

1036 cheyenne4:lipscomb% ./manage_externals/checkout_externals Processing externals description file : Externals.cfg Processing externals description file : Externals_CISM.cfg Processing externals description file : Externals_CLM.cfg Checking status of externals: cism, source_cism, mosart, ctsm, fates, ptclm, cime, Checking out externals: cism, mosart, ctsm, cime, Processing externals description file : Externals_CISM.cfg Checking out externals: source_cism, ERROR:root:In repo "source_cism": reference "7dd0e1aceb7c90e98248fef475e00f178e4af97f" does not appear to be a valid tag, branch or hash! Please verify the reference name (e.g. spelling), is available from: https://github.com/ESCOMP/cism

ERROR: In repo "source_cism": reference "7dd0e1aceb7c90e98248fef475e00f178e4af97f" does not appear to be a valid tag, branch or hash! Please verify the reference name (e.g. spelling), is available from: https://github.com/ESCOMP/cism

billsacks commented 6 years ago

@whlipscomb I can't reproduce the error you ran into with manage_externals: I tried pointing source_cism to a hash that had not yet been fetched in the current directory, then reran checkout_externals and (as it should) it fetched from the remote and then successfully checked out the hash. But I'm concerned about this. Please let me know if you run into this again, and if so, I'd like to work harder to try to reproduce it.

whlipscomb commented 6 years ago

@billsacks , I just did a fresh clone of cism-wrapper, checked out improve_stability, and had no problem with the manage_externals step. I can't explain what happened the first time, but hopefully it won't recur.

I'm running a TG1850G case now. So far so good after 100 years.

whlipscomb commented 6 years ago

@billsacks and @gunterl, I launched a 5 ka TG run on cheyenne using the improve_stability branch. As of now we're 3500 years in, with no signs of instability in the troublesome Kangerlussuaq or Jakobshavn regions. I ran through the output fields and everything looked good, including the snapshots of acab_applied, bmlt_applied and calving_rate. So I think we're good to go with our CISM release code and default config parameters.

billsacks commented 6 years ago

Fantastic, thanks for letting us know!

gunterl commented 6 years ago

This is great!

On Tue, May 15, 2018 at 6:41 AM, Bill Sacks notifications@github.com wrote:

Fantastic, thanks for letting us know!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ESCOMP/cism-wrapper/pull/16#issuecomment-389152334, or mute the thread https://github.com/notifications/unsubscribe-auth/AH0K-GTee_CcpSUaTx2vCHObQobW8Tflks5tys0RgaJpZM4T-dQ0 .