search

ESCOMP / CISM-wrapper

Community Ice Sheet Model wrapper for CESM
http://www.cesm.ucar.edu/models/cesm2.0/land-ice/
Other
3 stars 16 forks source link

can't use double-quoted file names in user_nl_cism #2

Closed billsacks closed 3 years ago

billsacks commented 6 years ago

Bill Sacks < sacks > - 2014-05-16 16:08:31 -0600 Bugzilla Id: 1978 Bugzilla CC: erik, lipscomb, mvertens,

For some reason it doesn't work to use double-quoted file names in user_nl_cism - these must be single-quoted. I have known about this problem since last year, but it once again caused a problem (for Gail Gutowski). I looked into this a year ago and couldn't figure it out, but I should revisit it at some point.

Perhaps it would be possible to put in place a workaround in CISM's build_namelist that translates double-quoted strings to single-quoted?

billsacks commented 6 years ago

Erik Kluzek < erik > - 2014-05-16 16:37:26 -0600

Hmmm. That's interesting, because there is logic in Namelist.pm to handle either one. I thought there might be a unit test for it as well, but perl5lib/t/04.t always uses single quote for strings.

So I switched a single quote string for double and it does still work. When I switched one that is validated it does NOT however. So I bet the problem is that the validation assumes a single quote. The validation should probably make sure there are quotes, but let either one pass.

billsacks commented 6 years ago

Bill Sacks < sacks > - 2014-05-16 19:00:37 -0600

Hi Erik,

Thanks for your reply. I think this is actually something cism-specific, related to its config file reader. But I can't remember the details (I looked into this about a year ago, then forgot about it).

billsacks commented 3 years ago

I'm not sure if this has still been an issue, but if so, it may be resolved with the upcoming conversion of buildnml to python (#49). Since I can't remember how the issue shows up, I'm not testing it, but I'm going to tentatively close this, and we can reopen it if it continues to be an issue.