Closed ekluzek closed 5 years ago
I believe this code was added by @whlipscomb and/or @Katetc . Given this:
!WHL - debug
character(len=150) :: message
I wonder if you can just remove this message variable and the associated print. Bill L?
Looks pretty simple to fix. I can do this after finishing the MG3 tag. I don't mind leaving a message write out with the tavg helper filename. But we can remove it if it's not necessary as well. I'm ambivalent.
Thanks for catching that Eric!
By the way, how I came upon this was from running the rtm testlist (the mosart test list passed without problems, and it should include cism as well)...
These tests passed
================================================================================
ERS_Ld5.f10_f10_musgs.I2000Clm50BgcCropRtm.cheyenne_gnu.rtm-default
ERS_Ld5.f10_f10_musgs.I2000Clm50BgcCropRtm.cheyenne_intel.rtm-default
ERS_Ld5.f10_f10_musgs.I2000Clm50BgcCropRtm.cheyenne_intel.rtm-rtmOff
ERS_Ld5.f10_f10_musgs.I2000Clm50BgcCropRtm.cheyenne_intel.rtm-rtmOnIceOff
SMS_D_Ld5.f10_f10_musgs.I2000Clm50BgcCropRtm.cheyenne_gnu.rtm-default
SMS_D_Ld5.f10_f10_musgs.I2000Clm50BgcCropRtm.cheyenne_intel.rtm-default
================================================================================
These tests failed
================================================================================
ERS_D_Ld5.f10_f10_musgs.I2000Clm50BgcCropRtm.cheyenne_intel.rtm-rtmOnFloodOnEffvelOn
ERS_Ld5.f10_f10_musgs.I2000Clm50BgcCropRtm.cheyenne_intel.rtm-rtmOnFloodOnEffvelOff
ERS_Ld5.f10_f10_musgs.I2000Clm50BgcCropRtm.cheyenne_intel.rtm-rtmOnFloodOnEffvelOn
I think the problem might just be that those RTM tests have longer names, so it must have just gone over the string length.
Erik, thanks for spotting this. I'm fine with removing the message variable and associated print.
Bill L.
On Tue, Jun 11, 2019 at 1:21 PM Erik Kluzek notifications@github.com wrote:
By the way, how I came upon this was from running the rtm testlist (the mosart test list passed without problems, and it should include cism as well)...
These tests passed
ERS_Ld5.f10_f10_musgs.I2000Clm50BgcCropRtm.cheyenne_gnu.rtm-default
ERS_Ld5.f10_f10_musgs.I2000Clm50BgcCropRtm.cheyenne_intel.rtm-default
ERS_Ld5.f10_f10_musgs.I2000Clm50BgcCropRtm.cheyenne_intel.rtm-rtmOff
ERS_Ld5.f10_f10_musgs.I2000Clm50BgcCropRtm.cheyenne_intel.rtm-rtmOnIceOff
SMS_D_Ld5.f10_f10_musgs.I2000Clm50BgcCropRtm.cheyenne_gnu.rtm-default
SMS_D_Ld5.f10_f10_musgs.I2000Clm50BgcCropRtm.cheyenne_intel.rtm-defaultThese tests failed
ERS_D_Ld5.f10_f10_musgs.I2000Clm50BgcCropRtm.cheyenne_intel.rtm-rtmOnFloodOnEffvelOn
ERS_Ld5.f10_f10_musgs.I2000Clm50BgcCropRtm.cheyenne_intel.rtm-rtmOnFloodOnEffvelOff
ERS_Ld5.f10_f10_musgs.I2000Clm50BgcCropRtm.cheyenne_intel.rtm-rtmOnFloodOnEffvelOnI think the problem might just be that those RTM tests have longer names, so it must have just gone over the string length.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ESCOMP/cism-wrapper/issues/27?email_source=notifications&email_token=ABU7CKP77WEGSTINFWC6YVDPZ73LXA5CNFSM4HXCAIW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXOG7TQ#issuecomment-500985806, or mute the thread https://github.com/notifications/unsubscribe-auth/ABU7CKPNZTMTWHMLM54T5UTPZ73LXANCNFSM4HXCAIWQ .
-- William Lipscomb National Center for Atmospheric Research Boulder, CO (505) 699-8016
This is something that @billsacks added in for cism2_1_31. The subroutine glc_io_write_history_tavg_helper was added and it creates a string in the variable "message" from the variable "filename", and the problem is that filename can actually be longer than message, so this becomes a problem if that's the case. The reverse should actually be true in this case.
This can be a problem running with DEBUG=TRUE and with cases that happen to have long filenames.
The error I get on cheyenne is:
The relevant part of the code is: