search

ESCOMP / CISM-wrapper

Community Ice Sheet Model wrapper for CESM
http://www.cesm.ucar.edu/models/cesm2.0/land-ice/
Other
3 stars 16 forks source link

Remove remnants of scripts to generate default i/o files #47

Closed billsacks closed 3 years ago

billsacks commented 3 years ago

@Katetc You changed the CISM build a while ago so that the i/o files are generated as part of the build process, right? I noticed that case directories still have Buildconf/cismIOconf, which contains the old scripts that users could use to regenerate these files manually. I'm thinking that this should be removed, and along with it, removing the relevant files from the source tree, which include bld/cismIO/cism.buildIO.template.csh, cime_config/cism.template, and maybe others. Do you agree?

Katetc commented 3 years ago

Yes, I added code to generate those files as part of the build. I thought I did remove the files that are no longer needed, but if you find some still hanging around, then please remove them as part of your cleanup. The CISM.template and the cism.buildIO.template.csh files may still be needed as the files are still generated from a template, it's just done automatically rather than by hand. ie, the csh file may be called from the cmake script. So, double check before removing anything permanently.

billsacks commented 3 years ago

Sorry, I'm dealing with too many threads already right now, which is why I opened this issue rather than just figuring out what needs to be removed. This was turning into a peeling onion.

billsacks commented 3 years ago

Actually, after a couple more minutes of looking, it may not be so bad, so I can take a stab at this. However, I see that cism.template is still invoked from cime, so I would need to leave something in place for a little while, until cime has been updated to no longer expect this. I'll put this in an upcoming cime PR.

I'm a little confused because in https://github.com/ESCOMP/CISM-wrapper/issues/18#issuecomment-419281858 you said you had already done this, so I'm not sure why these files are still here.

billsacks commented 3 years ago

Hmmm, it looks like you never made any changes to the CISM-wrapper code in #22 - only to the source_cism version. I think this will be easy enough, so I'll take it on.