search

ESCOMP / CISM-wrapper

Community Ice Sheet Model wrapper for CESM
http://www.cesm.ucar.edu/models/cesm2.0/land-ice/
Other
3 stars 15 forks source link

Advertise import fields even with noevolve #86

Closed billsacks closed 2 months ago

billsacks commented 3 months ago

This is needed for the MED -> GLC mapping to work in https://github.com/ESCOMP/CMEPS/pull/442. So the changes here and the changes in that CMEPS PR are inter-dependent (though it might work to bring in these CISM-wrapper changes before those CMEPS changes; I haven't tested that).

I have tested this by running aux_glc on derecho (intel & gnu) on this branch along with the changes from https://github.com/ESCOMP/CMEPS/pull/442 cherry-picked onto cmeps0.14.43. Failures were as expected:

    FAIL ERS_D_Ly3.f09_g17_gris4.T1850Gg.derecho_intel.cism-noevolve NLCOMP
    FAIL ERS_D_Ly3.f09_g17_gris4.T1850Gg.derecho_intel.cism-noevolve BASELINE /glade/derecho/scratch/sacks/aux_glc_240301164745/baselines: DIFF
    FAIL NCK_Ly3.f09_g17_gris20.T1850Gg.derecho_gnu COMPARE_base_multiinst
    FAIL SMS_Lm13.f10_f10_mg37.I1850Clm50SpG.derecho_intel.cism-noevolve NLCOMP
    FAIL SMS_Lm13.f10_f10_mg37.I1850Clm50SpG.derecho_intel.cism-noevolve BASELINE /glade/derecho/scratch/sacks/aux_glc_240301164745/baselines: DIFF

(The NCK test fails on master, too.) I confirmed that the diffs are as expected.

billsacks commented 3 months ago

It turns out that these changes require the above CMEPS changes.

Katetc commented 2 months ago

Since the CMEPS changes have been merged and tagged, I am going to bring in this PR and then open one that updates CISM-wrapper Externals as well. I will make the cismwrap_2_1_100 tag including both of these PRs so it builds and runs correctly.

whlipscomb commented 2 months ago

@Katetc — That sounds great. Thanks!