search

ESCOMP / CISM

Community Ice Sheet Model
GNU Lesser General Public License v3.0
6 stars 11 forks source link

SLAP issue with cce (cray compiler) #47

Open jedwards4b opened 2 years ago

jedwards4b commented 2 years ago

A runtime error is generated in libglimmer-solve/SLAP/xersla.f with the cce/11.0.2 compiler.

A fix is to change dimension messg(nmessg) to be character() in the file xersla.f

whlipscomb commented 2 years ago

@jedwards4b – As you may remember, the SLAP code isn't something we actively develop. It's legacy code that we carry around because it can be useful for testing new solvers in standalone CISM. We've talked about dropping it, in part because of issues like this.

For now, I'd suggest that we make this one fix and check it into the main branch. In the longer term, maybe we should modify the code so that CISM can be built in CESM without SLAP.

What do @billsacks and @Katetc think?

billsacks commented 2 years ago

@whlipscomb sounds reasonable. See also https://github.com/ESCOMP/CISM/issues/26 for some other minor SLAP issues that should be fixed, and https://github.com/ESCOMP/CISM/issues/14 for thoughts on removing SLAP.

whlipscomb commented 2 years ago

In the short term, I'll ask @Katetc to do a quick survey to find and fix the problematic lines of code in SLAP, and check the changes into the main branch. In the long term, I'll plan to remove SLAP from the CESM build. I'm sorry this remains an issue.

Katetc commented 2 years ago

Sounds good to me! This should be pretty straight-forward.