ESCOMP / CMEPS

NUOPC Community Mediator for Earth Prediction Systems
https://escomp.github.io/CMEPS/
24 stars 79 forks source link

Update for HAFS coupling mode and changes that are required for WW3 coupling under UFS #217

Closed uturuncoglu closed 3 years ago

uturuncoglu commented 3 years ago

Description of changes

This PR aims to bring HAFS related following changes to the upstream,

Specific notes

Contributors other than yourself, if any: @danrosen25

CMEPS Issues Fixed (include github issue #):

Are changes expected to change answers?

Any User Interface Changes (namelist or namelist defaults changes)?

Testing performed if application target is CESM:(either UFS-S2S or CESM testing is required):

Testing performed if application target is UFS-coupled:

Testing performed if application target is UFS-HAFS:

Hashes used for testing:

uturuncoglu commented 3 years ago

All CESM prealpha test are run and the failed tests are listed in the PR description. It seems that they are not related with this PR. I'll also run CESM testlist_drv.xml and nuopc scripts_regression_tests.py

mvertens commented 3 years ago

@uturuncoglu - you do not need to run the testlist_drv.xml if you have run the prealpha tests.

uturuncoglu commented 3 years ago

@mvertens Okay. Actually, I have already run them but I could not access to the results because Cheyenne is down.

uturuncoglu commented 3 years ago

@jedwards4b @DeniseWorthen I just wonder if you find chance to look at this PR.

DeniseWorthen commented 3 years ago

@uturuncoglu I'm sorry, I forgot. Have you tested this PR in the ufs-weather-model RT? It wasn't quite clear to me in the description.

uturuncoglu commented 3 years ago

@DeniseWorthen Yes, this PR is tested couple of times under UFS by running full RTs as well as running HAFS specific RTs (they are not part of UFS yet) and HAFS application tests and there is no issue. Here is the specific branch that is tested

https://github.com/hafs-community/ufs-weather-model/tree/feature/hafs_sync_20210716

it has both CDEPS and WW3 related changes. Maybe you could just run the standard coupled case in your side to double check and make sure.

DeniseWorthen commented 3 years ago

@uturuncoglu That's great. I can approve now.

uturuncoglu commented 3 years ago

@jedwards4b I run the nuopc scripts_regression_tests.py but I don't have the results since Cheyenne is down. CESM prealpha tests were fine. If you want I could wait for merge until Cheyenne will be available again.