ESCOMP / CMEPS

NUOPC Community Mediator for Earth Prediction Systems
https://escomp.github.io/CMEPS/
24 stars 79 forks source link

Namelist trigger for passing channel depth fields from ROF to LND #244

Closed ekluzek closed 2 years ago

ekluzek commented 3 years ago

Description of changes

Add a namelist trigger to turn on passing of channel depth fields needed for the hillslope model.

Specific notes

Contributors other than yourself, if any: @mvertens @swensosc

CMEPS Issues Fixed (include github issue #): Fixes #241 Fixes #245

Are changes expected to change answers?

Any User Interface Changes (namelist or namelist defaults changes)?

Add flds_r2l_stream_channel_depths to ALLCOMPS_attributes config file

Testing performed if application target is CESM:(either UFS-S2S or CESM testing is required):

SMS_D_Ld5_Vnuopc.f10_f10_mg37.I2000Clm50BgcCrop.cheyenne_intel.mosart-default

Can add flds_r2l_stream_channel_depths to user_nl_cpl and tdepth fields are added when on, and otherwise off.

Hashes used for testing:

ekluzek commented 3 years ago

Let me know if you want me to do more testing. I figured these changes are specific enough to running with MOSART that the test I ran was sufficient. But, I could run more tests.

ekluzek commented 2 years ago

@mvertens and/or @jedwards4b could this be approved and merged in? If you need me to do more work or testing on it, I'm happy to, just let me know. Thanks.

mvertens commented 2 years ago

@ekluzek - this looked fine.