ESCOMP / CMEPS

NUOPC Community Mediator for Earth Prediction Systems
https://escomp.github.io/CMEPS/
24 stars 79 forks source link

cmeps directory refactor #256

Closed mvertens closed 3 years ago

mvertens commented 3 years ago

Description of changes

CMEPS directory refactor

Specific notes

The following directory changes were made:

Contributors other than yourself, if any: CMEPS Issues Fixed: None Are changes expected to change answers? bit-for-bit Any User Interface Changes (namelist or namelist defaults changes)? No

Testing performed: CESM testing: verified that the following tests are bfb with cesm2_3_alpha07a on cheyenne : IRT_Ld7.f09_g17.BHIST.cheyenne_intel.allactive-defaultio ERS_Ld3.f45_g37_rx1.A.cheyenne_intel UFS testing: ufs-weather-model 0cf60348 using CMEPS e703499

mvertens commented 3 years ago

@uturuncoglu @DeniseWorthen - could you please test this in your configurations and make sure they work. @jedwards4b and I talked and we are not worried about the Travis test failure.

DeniseWorthen commented 3 years ago

I tested the compile after the last commit and was able to compile after changing our CMakeLists. I also tested deleting the dtypes.h and genf90.pl. I expect everything to pass but I will test again just to verify.

mvertens commented 3 years ago

Thank you!

On Mon, Nov 15, 2021 at 6:58 PM Denise Worthen @.***> wrote:

I tested the compile after the last commit and was able to compile after changing our CMakeLists. I also tested deleting the dtypes.h and genf90.pl. I expect everything to pass but I will test again just to verify.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ESCOMP/CMEPS/pull/256#issuecomment-969671272, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB4XCE67E2K4WADPPV3ZI23UMG3EPANCNFSM5H7L2D4Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

-- Dr. Mariana Vertenstein CESM Software Engineering Group Head National Center for Atmospheric Research Boulder, Colorado Office 303-497-1349 Email: @.***

DeniseWorthen commented 3 years ago

The full RT suite passes for ufs-weather for both INTEL and GNU. We can remove dtypes.h and genf90.pl from the CMEPS/ufs directory.