ESCOMP / CMEPS

NUOPC Community Mediator for Earth Prediction Systems
https://escomp.github.io/CMEPS/
24 stars 79 forks source link

new dynamic memory allocate in med_internalstate #263

Closed mvertens closed 2 years ago

mvertens commented 2 years ago

Description of changes

This PR implements new dynamic memory allocation in med_internalstate_mod and removes the hard-wiring of ncomp settings in esmFlds.F90. It resolves #237 and #260.

Specific notes

Contributors other than yourself, if any: None

CMEPS Issues Fixex: #237 and #260

Are changes expected to change answers?

Any User Interface Changes (namelist or namelist defaults changes)?

Testing performed if application target is CESM:(either UFS-S2S or CESM testing is required):

Testing performed if application target is UFS-coupled:

Testing performed if application target is UFS-HAFS:

Hashes used for testing:

mvertens commented 2 years ago

Yes!!! thank you for catching this.

On Mon, Dec 27, 2021 at 9:36 AM Jim Edwards @.***> wrote:

@.**** approved this pull request.

In mediator/med_constants_mod.F90 https://github.com/ESCOMP/CMEPS/pull/263#discussion_r775569003:

@@ -16,6 +16,6 @@ module med_constants_mod real(R8), parameter :: med_constants_czero = 0.0_R8 ! spval integer, parameter :: med_constants_ispval_mask = -987987 ! spval for RH mask values integer, parameter :: med_constants_SecPerDay = 86400 ! Seconds per day

  • integer :: med_constants_dbug_flag = 0
  • integer :: med_constants_dbug_flag = 15

Do you want to reset this to 0?

— Reply to this email directly, view it on GitHub https://github.com/ESCOMP/CMEPS/pull/263#pullrequestreview-840462121, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB4XCEYTRDVYQQ2BLQAJKXLUTCIZLANCNFSM5KZHIZAA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

-- Dr. Mariana Vertenstein CESM Software Engineering Group Head National Center for Atmospheric Research Boulder, Colorado Office 303-497-1349 Email: @.***

mvertens commented 2 years ago

@denise - thanks so much for your quick response to the testing! That is super helpful.

billsacks commented 2 years ago

@mvertens - Thanks a lot for this change to make the number of ice sheets dynamic!