ESCOMP / CMEPS

NUOPC Community Mediator for Earth Prediction Systems
https://escomp.github.io/CMEPS/
24 stars 79 forks source link

Units of coordinate dimensions of mediator history files #277

Closed uturuncoglu closed 1 year ago

uturuncoglu commented 2 years ago

It seems that the units of coordinate dimensions in mediator history are not consistent. Under UFS application, the units of the Med_aoflux_atm_lon and Med_aoflux_atm_lat are in radian but Med_aoflux_ocn_lon and Med_aoflux_ocn_lat are in degrees. If I use ncdump,

    double Med_aoflux_atm_lat(time, Med_aoflux_atm_ny, Med_aoflux_atm_nx) ;
        Med_aoflux_atm_lat:long_name = "latitude" ;
        Med_aoflux_atm_lat:units = "degrees_north" ;
        Med_aoflux_atm_lat:standard_name = "latitude" ;

    double Med_aoflux_ocn_lat(time, Med_aoflux_ocn_ny, Med_aoflux_ocn_nx) ;
        Med_aoflux_ocn_lat:long_name = "latitude" ;
        Med_aoflux_ocn_lat:units = "degrees_north" ;
        Med_aoflux_ocn_lat:standard_name = "latitude" ;

but Med_aoflux_atm_lon and Med_aoflux_atm_lat are not in degrees.

DeniseWorthen commented 1 year ago

@uturuncoglu I didn't realize this issue existed on ESCOMP, but I think it was fixed by PR https://github.com/ESCOMP/CMEPS/pull/338. I ran the cpld_control_noaero_p8_agrid test and the ATM units for lat and lon are now radians:

Med_aoflux_ocn_lat:units = "degrees_N"
Med_aoflux_ocn_lon:units = "degrees_E" 

Med_aoflux_atm_lat:units = "radians" 
Med_aoflux_atm_lon:units = "radians"
uturuncoglu commented 1 year ago

@DeniseWorthen Thanks for the fix. So, we could close this issue now. Right?

DeniseWorthen commented 1 year ago

Yes.