ESCOMP / CMEPS

NUOPC Community Mediator for Earth Prediction Systems

https://escomp.github.io/CMEPS/

24 stars 79 forks source link

build workflow fails due to old version of ESMF #297

Closed uturuncoglu closed 2 years ago

uturuncoglu commented 2 years ago

The build workflow fails with following PR since it uses ESMF_XGridGet interface and I think it requires newer version of ESMF. I could able to compile it with esmf/8.3.0b09. @jedwards4b do you know which version is used by the build workflow? Is it possible to update it easily?

uturuncoglu commented 2 years ago

@jedwards4b I think the workflow is using ESMF_8_2_0_beta_snapshot_14

jedwards4b commented 2 years ago

298 Should take care of the issue.

jedwards4b commented 2 years ago

Changing the ESMF build for this is easy. Just edit this line: https://github.com/ESCOMP/CMEPS/blob/master/.github/workflows/extbuild.yml#L22 However note that in the PR ESMF is checked out directly from github and so the version looks like v8.3.0b13

uturuncoglu commented 2 years ago

@jedwards4b btw, I am not sure why it is failing if it points to v8.3.0b13.

jedwards4b commented 2 years ago

typo in the script...

jedwards4b commented 2 years ago

Fixed in #298 @uturuncoglu merge master into your pr, it should now pass.

uturuncoglu commented 2 years ago

I am not sure but the build workflow still picks ESMF_VERSION: ESMF_8_2_0_beta_snapshot_14. I could see it in the build log env I restart the all jobs. Any idea?