search

ESCOMP / CMEPS

NUOPC Community Mediator for Earth Prediction Systems
https://escomp.github.io/CMEPS/
24 stars 79 forks source link

LND2ROF_FMAPNAME and ROF2LND_FMAPNAME can be set in the XML for case -- but don't actually do anything #346

Closed ekluzek closed 1 year ago

ekluzek commented 1 year ago

This is true in cmeps0.13.81. You can set LND2ROF_FMAPNAME and ROF2LND_FMAPNAME for a case, but they don't actually change the nupoc.runconfig to set the nuopc.runconfig configuration values: lnd2rof_map and rof2lnd_map. This obviously needs to be connected so that you can provide a mapping file for these cases. This is a critically important feature for working with mizuRoute.

ekluzek commented 1 year ago

I think this might have been working in the past and then was broken at some point. I'll investigate if that's the case or not.

ekluzek commented 1 year ago

It looks like this was broken with commit b4a19837

billsacks commented 1 year ago

Nice work tracking this down, @ekluzek !

ekluzek commented 1 year ago

I have a branch that we are testing that gets this to work for us. But, in the long-term I think this needs some discussion on the right way to do this. So I'm thinking that I should talk with @jedwards4b and @billsacks about this? Anyone else that should be involved? And should I just propose a meeting in the next few weeks?

jedwards4b commented 1 year ago

If you want these to work you just need to modify namelist_definition_drv.xml and add modify_via_xml="LND2ROF_FMAPNAME" and <value>$LND2ROF_FMAPNAME</value> you can look to ROF2OCN_FMAPNAME for an example.

ekluzek commented 1 year ago

@jedwards4b I have a simple fix along those lines that I'll submit a PR for. The larger thing that I'm concerned about is that there a bunch of XML variables that are disconnected from the namelist, so they do nothing. That's the bigger issue to discuss. I'll create an issue for that as well.