ESCOMP / CMEPS

NUOPC Community Mediator for Earth Prediction Systems
https://escomp.github.io/CMEPS/
24 stars 79 forks source link

fix issue with xgrid reproducibility #364

Closed jedwards4b closed 1 year ago

jedwards4b commented 1 year ago

Description of changes

Adds optional flags to ESMF_FieldRegridStore command to make xgrid reproducable.

Specific notes

Contributors other than yourself, if any: mvertens, esmf team

CMEPS Issues Fixed (include github issue #):

Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial)

Any User Interface Changes (namelist or namelist defaults changes)?

Testing performed

Testing performed if application target is CESM:

Testing performed if application target is UFS-HAFS:

Hashes used for testing:

jedwards4b commented 1 year ago

@uturuncoglu what additional change are you suggesting? The tests were rerun with the change that I made and no further changes are required.

uturuncoglu commented 1 year ago

@jedwards4b Okay. It is my fault. Those are ESMF_FieldRegrid calls not Store.

mvertens commented 1 year ago

@jedwards4b, @uturuncoglu - from a separate email it seems like this change requires a new ESMF tag. Is this correct. If so - this needs to be documented in this PR. Working at other institutions, requirements of new ESMF tags can be challenging. And if indeed this is the case, this will not be backwards compatible with older ESMF libraries. Please clarify.

jedwards4b commented 1 year ago

@mvertens - I don't think that is the case with this one. I have another issue to add a message indicating the minimum required esmf version.