search

ESCOMP / CMEPS

NUOPC Community Mediator for Earth Prediction Systems
https://escomp.github.io/CMEPS/
24 stars 79 forks source link

avoid integer overflow by skipping mediator in restart loop #460

Closed jedwards4b closed 6 months ago

jedwards4b commented 6 months ago

Description of changes

This loop in med_phases_restart_mod.F90 was causing integer overflow because the med component should not be included. This was only happening with the nag compiler in debug mode and would not normally be a problem since integer overflows are ignored (except by nag in debug mode) and the resulting values were never used.

Specific notes

Contributors other than yourself, if any:

CMEPS Issues Fixed (include github issue #):

Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial)

Any User Interface Changes (namelist or namelist defaults changes)?

Testing performed

Please describe the tests along with the target model and machine(s) If possible, please also added hashes that were used in the testing

mvertens commented 6 months ago

@jedwards - what testing was done for this? Can you please run a few tests to demonstrate that this fix does not adversely effect other configurations.

ekluzek commented 6 months ago

We have a long lists of tests that fail in our CTSM PR https://github.com/ESCOMP/CTSM/pull/2539. It would be good to have this come in as a tag so we can show those tests PASS.

What testing needs to be done for this to come in? Maybe the aux_cmeps and aux_clm test lists in a CESM checkout?