ESCOMP / CMEPS

NUOPC Community Mediator for Earth Prediction Systems
https://escomp.github.io/CMEPS/
24 stars 79 forks source link

Simplify logic for glc_renormalize_smb #495

Closed billsacks closed 3 months ago

billsacks commented 3 months ago

Description of changes

Remove the glc_renormalize_smb option on_if_glc_coupled_fluxes. This had been the default. Change the default to 'on'. This maintains consistent behavior between different configurations.

Specific notes

Contributors other than yourself, if any:

CMEPS Issues Fixed (include github issue #): Resolves ESCOMP/CMEPS#133

Are changes expected to change answers? YES: changes answers by greater than roundoff for T compsets (active GLC with DLND) (now SMB is remapped with renormalization for T compsets by default); answers should be bit-for-bit in all other configurations (unless there is some configuration/combination that I'm not thinking of...)

Any User Interface Changes (namelist or namelist defaults changes)? Removes on_if_glc_coupled_fluxes option to glc_renormalize_smb

Testing performed

Please describe the tests along with the target model and machine(s) If possible, please also added hashes that were used in the testing

Tested in the context of cesm3_0_beta02: ran:

All tests passed; the T compset test changed answers as expected but the other two were bit-for-bit.

billsacks commented 3 months ago

@mvertens @whlipscomb @Katetc - this (finally) resolves #133 in the way we discussed there a few years ago. Note that this will change answers for T compsets, because now the SMB renormalization is always on by default (but it can still be turned off if desired).