ESCOMP / CTSM

Community Terrestrial Systems Model (includes the Community Land Model of CESM)
http://www.cesm.ucar.edu/models/cesm2.0/land/
Other
306 stars 310 forks source link

Use data glc model where we used to use CISM2%NOEVOLVE #1136

Open billsacks opened 4 years ago

billsacks commented 4 years ago

In compsets that currently use CISM2%NOEVOLVE – and will soon change to use SGLC – we'd like to instead use a data glc model in a time-constant mode. This should provide all of the benefits that we currently get from CISM2%NOEVOLVE: dictating glacier area and topographic heights over the ice sheet domain and providing a high-resolution grid onto which SMB and other fields can be downscaled.

We plan to develop this data glc model in CDEPS, which relies on NUOPC. So we will wait to make this switch until we are using NUOPC as a standard mode of operation (footnote this has happened now).

Definition of done:

billsacks commented 4 years ago

Blocked: depends on https://github.com/ESCOMP/CDEPS/issues/25

ekluzek commented 6 months ago

LIWG is going to support a DGLC model rather than CISM%NOEVOLVE mode for CESM3. This means rather than fixing #2222 for CISM/CTSM the ability to run cases with DGLC will be setup. This is important for fully coupled compsets so that negative runoff is NOT sent to the ocean model. It looks right now the only CISM%NOEVOLVE compsets and tests are B1850 cases. So minimally we would only need to have a few tests around DGLC for 1850 with Bgc-Crop.

I added some notes about what needs to happen to the introduction for a "Definition of Done" above.

billsacks commented 6 months ago

@ekluzek - responding to and clarifying some points:

ekluzek commented 4 months ago

@billsacks and @Katetc I think this is something that's required for the June/30th science capability/functionality freeze correct? If so I'll mark it that way.

wwieder commented 4 months ago

Is this required for the summer science capability freeze or before the CESM3.0 release?

wwieder commented 4 months ago

@ekluzek thinks it's for the later (CESM 3 release), but is this accurate @billsacks, @whlipscomb, @Katetc?

billsacks commented 4 months ago

Good question.

For scientifically-supported configurations, they should use ideally either DGLC or an evolving CISM by the science capability freeze, since that will be greater-than-roundoff answer-changing relative to using SGLC. I'm not clear on which configurations will be using DGLC and which will be using an evolving CISM; that may require some discussion, which I guess should happen ASAP.

That said, the changes shouldn't be huge, so this could probably happen at lower priority than other changes needed by this date.

(I assume we're just talking about I compsets here, given that this is a CTSM issue. For B compsets, getting them correct will be higher priority.)

wwieder commented 3 weeks ago

This came up at co-chairs today, with the TODO to decide on running stub vs. data glacier models in F and I compsets. Maybe @Katetc or @billsacks can weigh in here to help us understand when or why we'd want to run with DGLC vs. SGLC by default moving forward?

billsacks commented 3 weeks ago

My feeling is that I and F compsets should stay consistent with B compsets in this respect and generally use DGLC (or an evolving CISM) in nearly all cases. An exception would be regional cases that don't involve Greenland or Antarctica (I'm not sure if it would work to use DGLC in those cases; maybe it would).

The main advantages of this are what's laid out in the initial comment of this issue: dictating glacier area and topographic heights over the ice sheet domain and providing a high-resolution grid onto which SMB and other fields can be downscaled.

In B compsets an additional advantage of DGLC is that @Katetc recently put in place some improved handling of runoff fluxes to better handle negative runoff over ice sheets; this probably isn't important for I or F compsets, but it seems best to stay consistent with B compsets in this respect.

wwieder commented 3 weeks ago

Thanks for this explantation, Bill.

So single point and regional cases should use a SGLC, with DGLC uses everywhere else. This is easy to set up for single point compsets, but a bit trickier in regional cases. I guess our documentation and examples just need to be clear for setting up regional cases with long-name compsets?

billsacks commented 3 weeks ago

So single point and regional cases should use a SGLC, with DGLC uses everywhere else. This is easy to set up for single point compsets, but a bit trickier in regional cases. I guess our documentation and examples just need to be clear for setting up regional cases with long-name compsets?

Yes, that sounds right. It may be worth experimenting and seeing if things happen to work when using DGLC with a regional configuration that doesn't include the DGLC domain. I wouldn't be surprised if you run into errors with that, but it might just work.

Note that I think this is similar to the situation we had with CESM2.1 / CLM5: There, I think we used CISM2%NOEVOLVE for most configurations, but SGLC for single-point / regional configurations.