search

ESCOMP / CTSM

Community Terrestrial Systems Model (includes the Community Land Model of CESM)
http://www.cesm.ucar.edu/models/cesm2.0/land/
Other
308 stars 311 forks source link

mkunitymap.ncl #1511

Open ekluzek opened 3 years ago

ekluzek commented 3 years ago

Brief summary of bug

mkunitymap.ncl has a small bug in it when paired with ESMF versions that ignore -src_type and -dst_type.

General bug information

CTSM version you are using: ctsm5.1.dev058 Does this bug cause significantly incorrect results in the model's science? No Configurations affected: Regional cases

Details of bug

The "conventions" attribute on the SCRIP mapping file needs to be "SCRIP" so that ESMF knows that it's a SCRIP mapping file. This wasn't needed before because we use the scr_type and dst_type options that explicitly told it what type it was. That option was deprecated and now is non-functional in newer ESMF versions so it's required to have the attribute set.

ekluzek commented 3 years ago

Another aspect of this (that I should probably make another issue) is that we think mkunitymap.ncl may no longer need to be used. It was required because ESMF couldn't do a unity mapping. It looks like ESMF can now at least do that, but we need to make sure the mapping file works.