Open jkshuman opened 1 year ago
updated to identify that if this script exists this issue can be closed by including script in the NCAR-NEON repo.
As background, the current neon_sites_dompft.csv was created by hand, as we couldn't find a clean or way to expeditiously generate information about the dominant PFT from data NEON provided. This led to the bug in #1933, but I'd still argue that the file is 'good enough' for the current system.
Moving forward with FATES capabilities, it's likely worth changing this. For example, the neon web site has a field site table that can be downloaded (to provide lat-lon). As I mentioned in #1934, I wonder if script that @adrifoster is creating should live on the NEON side, which already includes scripts that pre-processes NEON meteorological and flux tower data for use in CLM? Alternatively, I guess the script could also go into a preprocessing surface data repository that's external to the main CTSM repo.
Simulation at NEON sites uses a wrapper script to subset data, download neon data and update the surface data based on that NEON data. This wrapper script uses a NEON specific csv file with information on site name, domain, lat, lon, dominant pft, and years of data.
This NEON csv file should be create programmatically so that it is reproducible and bugs are caught more easily. If this already exists, a link needs to be provided or maintained in the NCAR_NEON repo. The designation of dominant pft should have documentation to identify the method by which this pft is set.
definition of done: script to generate the NEON csv file in the NCAR-NEON repo
Highlighting here https://github.com/ESCOMP/CTSM/issues/1934 which will use NEON inventory data to determine percentage of PFT in the surface data files and #PR1932 for further discussion and figures by @adrifoster on the mixture of species at a set of NEON sites.