ESCOMP / CTSM

Community Terrestrial Systems Model (includes the Community Land Model of CESM)
http://www.cesm.ucar.edu/models/cesm2.0/land/
Other
310 stars 315 forks source link

Exit gracefully when using a non-fates restart file to interpolate to a simulation with fates #212

Open ekluzek opened 6 years ago

ekluzek commented 6 years ago

You can't use a non-fates restart file to interpolate initial conditions to a simulation with fates. I don't think we will fix this, but we want to document it. And also add some general ability in so this won't happen out of the box. So for a fates simulation the model shouldn't try to interpolate from non-fates initial conditions. And because of #211 it shouldn't try to interpolate from a fates restart file either.

ekluzek commented 6 years ago

By the way it dies horribly with a seg fault with things like this:

1613: clmfates_interfaceMod.F90:: reading fates_mid_moisture_Slope 1613: clmfates_interfaceMod.F90:: reading fates_alpha_FMC 1613: clmfates_interfaceMod.F90:: reading fates_max_decomp 1613: clmfates_interfaceMod.F90:: reading q10_mr 1613: clmfates_interfaceMod.F90:: reading froz_q10 1793: total area is wrong in update_hlm_dynamics 0.0000000000000000 1793: total area is wrong in update_hlm_dynamics 0.0000000000000000 1793: total area is wrong in update_hlm_dynamics 0.0000000000000000 1793: 1793:Program received signal SIGSEGV: Segmentation fault - invalid memory reference. 1793:

billsacks commented 6 years ago

@ekluzek since this is labeled as wontfix, should it be closed?

rgknox commented 6 years ago

I would argue that there just isn't enough information in a non-FATES restart to initialize a FATES simulation. It could be done, but we would be adding lots of assumptions on canopy structure. I support the idea that it shouldn't be allowed, and should exit gracefully.

ekluzek commented 6 years ago

We should just change this so that it dies more gracefully and tells you what the problem is.