PLUMBER2 refactoring inputdata adjustments

ESCOMP / CTSM

Community Terrestrial Systems Model (includes the Community Land Model of CESM)

http://www.cesm.ucar.edu/models/cesm2.0/land/

Other

309 stars 313 forks source link

PLUMBER2 refactoring inputdata adjustments #2410

Open TeaganKing opened 8 months ago

TeaganKing commented 8 months ago

[x] Move data to CESM inputdata
[x] rimport the data above
[x] Point to the new locations in usermod scripts (https://github.com/ESCOMP/CTSM/blob/8d3468597b0b9bb1db351f755c6662bb500e4b96/tools/site_and_regional/plumber2_usermods.py)
[x] Redo the users mods and update them

samsrabin commented 8 months ago

These issues are introduced by #2155 but are okay to be resolved after that comes in.

slevis-lmwg commented 7 months ago

I'm happy to help with the move of data to /inputdata and subsequent ./rimport.

First I would like to have a quick discussion of what exactly (datm, lai_streams, fsurdat files?) needs to move where exactly. Under /inputdata I see:

/atm/datm7/CLM1PT_data
/lnd/clm2/lai_streams
for fsurdat we already have a clear setup under /lnd/clm2/surfdata_esmf

wwieder commented 7 months ago

This is nearly addressed in #2155. The there are a few outstanding TODO items in plumber2_usermods.py that we can discuss. These include:

[ ] updating usermods to point to the 5.2 surface data @slevis-lmwg already created
[ ] adding PLUMBER2SITE to cdeps.

Should these be added to the list in the first comment of the issue?

TeaganKing commented 4 months ago

I wanted to follow up on the to do items in this ticket.

I'm not sure of the rimport status. @slevis-lmwg do you know the status of this? I think we may need to loop in Will or Erik if those questions from above are still unclear.
Updating usermods is being done in #2485
Adding PLUMBER2SITE to CDEPS is being done in CDEPS PR #262.

slevis-lmwg commented 4 months ago

Regarding rimport, we never followed up regarding my question above. Before I execute the command, I would like confirmation that these are the correct directories that need rimporting:

/glade/campaign/cesm/cesmdata/inputdata/atm/datm7/CLM1PT_data/PLUMBER2
/glade/campaign/cesm/cesmdata/inputdata/lnd/clm2/lai_streams/PLUMBER2
/glade/campaign/cesm/cesmdata/inputdata/lnd/clm2/surfdata_esmf/PLUMBER2

A "thumbs up" to this post will do, and I will go ahead with the rimport.

TeaganKing commented 4 months ago

Ok thanks Sam. I'm not totally sure, so I'm going to tag @wwieder about this one...

TeaganKing commented 3 months ago

Hi @slevis-lmwg , I was just chatting with @wwieder and we'll want to use the following directories for the rimport. $DIN_LOC_ROOT/atm/datm7/CLM1PT_data/PLUMBER2 $DIN_LOC_ROOT/lnd/clm2/lai_streams/PLUMBER2 $DIN_LOC_ROOT/lnd/clm2/surfdata_esmf/PLUMBER2

slevis-lmwg commented 3 months ago

@TeaganKing thank you for bringing this up in today's meeting. I ran ./rimport just now to get all the files from these three directories onto the repository. This is done in /glade/campaign/cesm/cesmdata/inputdata:

./rimport -list plumber_datm.list
./rimport -list plumber_lai_streams.list
./rimport -list plumber_fsurdat.list

TeaganKing commented 3 months ago

Fantastic, thanks so much @slevis-lmwg !