ESCOMP / CTSM

Community Terrestrial Systems Model (includes the Community Land Model of CESM)
http://www.cesm.ucar.edu/models/cesm2.0/land/
Other
308 stars 311 forks source link

Temporarily add back a T42 dataset for CAM #2486

Open ekluzek opened 5 months ago

ekluzek commented 5 months ago

Brief summary of bug

The CAM test

SMS_D_Ln9_Vnuopc.T42_T42.FSCAM.derecho_intel.cam-scam_mpace_outfrq9

fails in cesm2_3_alpha17d and will also fail for the CAM testlist.

General bug information

CTSM version you are using:ctsm5.2.0

Does this bug cause significantly incorrect results in the model's science? No

Configurations affected: SCAM

Details of bug

In ctsm5.2.0 we removed support for T42 surface datasets in align with the "Grids in CESM3 document".

Definition of done:

ekluzek commented 5 months ago

We should just add a 2000 surface dataset for this. And we should remove the support for it when CAM no longer needs it.

slevis-lmwg commented 5 months ago

We should just add a 2000 surface dataset for this. And we should remove the support for it when CAM no longer needs it.

@ekluzek for now I will not add this one to the mksurfdata_esmf Makefile because you labeled it "temporary" but maybe the decision depends on when CAM will no longer need it.

ekluzek commented 5 months ago

@slevis-lmwg yes I actually had thought CAM had already moved away from this requirement. But, obviously not. So I've linked this to a CAM issue.

This is also a change they have committed to by CESM3, so I think we just keep this temporary file in place. In ctsm5.3.0 we'll update datasets, but leave this one in place since ctsm5.3.0 will be backwards compatible with ctsm5.2.0 datasets.

slevis-lmwg commented 5 months ago

I generated the new file's namelist using these settings: ./gen_mksurfdata_namelist --res T42 --start-year 2000 --end-year 2000

The new file is ready: /glade/campaign/cesm/cesmdata/inputdata/lnd/clm2/surfdata_esmf/ctsm5.2.0/surfdata_T42_hist_2000_78pfts_c240425.nc

@ekluzek if this looks good to you, I can ./rimport the file and close this issue.

ekluzek commented 5 months ago

@slevis-lmwg awesome. I did a ncdump -h on the file and it looks great. I Actually neglected to point out other steps that need to be done, as we need a CTSM tag for this that will go into cesm2_3_alpha17f. So I listed those steps at the top.

slevis-lmwg commented 5 months ago

I checked off all the TODOs. For the last one, I would have chosen "copy from ctsm5.2.002" since we're making a 2-line addition to an .xml file that affects nothing. But making a copy doesn't apply anymore. I just need to merge this to b4b-dev next.

@ekluzek I requested a review from you, in order to merge.

ekluzek commented 5 months ago

In CSEG we figured this will likely come in with cesm2_3_beta17, but it isn't required until cesm2_3_beta18. Since, this is on the b4b-dev branch it will just come in on Thursday.

ekluzek commented 5 months ago

This was done in #2495 and cam in with ctsm5.2.003.

ekluzek commented 2 weeks ago

This showed up again in cesm3_0_beta03 testing as we didn't have it in place for ctsm5.3.0. We will be able to finally removing it in ctsm5.4.0 since SCAM is moving to ne3np4 soon (see #2768).

Here's the test that failed for @fischer-ncar

PEND SMS_D_Ln9.T42_T42.FSCAMMPACE.derecho_intel.cam-outfrq9s RUN missing input file 'inputdata/lnd/clm2/surfdata_esmf/ctsm5.3.0/surfdata_T42_hist_2000_78pfts_c240908.nc' doesn't exist

@slevis-lmwg is going to make a new file and label it with the filename in namelist defaults, which will get the test to pass.

slevis-lmwg commented 2 weeks ago

I generated the mksurfdata_esmf namelist with ./gen_mksurfdata_namelist --start-year 2000 --end-year 2000 --res T42

@fischer-ncar the job is running, so the file should be ready in less than an hour here: /glade/derecho/scratch/slevis/temp_work/new_rawdata/tools/mksurfdata_esmf/surfdata_T42_hist_2000_78pfts_c240927.nc

fischer-ncar commented 2 weeks ago

@slevis-lmwg is it okay if I go ahead and copy surfdata_T42_hist_2000_78pfts_c240927.nc to the inputdata directory on derecho?

slevis-lmwg commented 2 weeks ago

Yes, absolutely.

fischer-ncar commented 2 weeks ago

@slevis-lmwg can you change to file creation date to c240908?

slevis-lmwg commented 2 weeks ago

Yes, I had forgotten that detail. I copied the file to /inputdata and renamed it.