search

ESCOMP / CTSM

Community Terrestrial Systems Model (includes the Community Land Model of CESM)
http://www.cesm.ucar.edu/models/cesm2.0/land/
Other
305 stars 307 forks source link

add hillslope_fsat_equals_zero #2600

Closed swensosc closed 3 months ago

swensosc commented 3 months ago

Description of changes

Add a namelist variable to toggle fsat calculation for hillslope columns

Specific notes

the topmodel-based fsat surface runoff scheme is not appropriate for upland hillslope columns, so allow user to set upland hillslope column fsat values to zero

Contributors other than yourself, if any: None

CTSM Issues Fixed (include github issue #): None

Are answers expected to change (and if so in what way)? yes, for hillslope cases; changing fsat will change surface runoff

Any User Interface Changes (namelist or namelist defaults changes)? New parameter hillslope_fsat_equals_zero (default true).

Does this create a need to change or add documentation? Did you do so? No

Testing performed, if any: aux_clm mostly okay compared to tmp-240620.n02.ctsm5.2.007. However, test LILACSMOKE_D_Ld2.f10_f10_mg37.I2000Ctsm50NwpSpAsRs.derecho_intel.clm-lilac has some weird namelist results:

2024-06-24 13:17:38: NLCOMP
Missing baseline namelist '/glade/campaign/cgd/tss/ctsm_baselines/tmp-240620.n02.ctsm5.2.007/LILACSMOKE_D_Ld2.f10_f10_mg37.I2000Ctsm50NwpSpAsRs.derecho_intel.c
lm-lilac/CaseDocs/nuopc.runconfig'
Comparison failed between '/glade/derecho/scratch/samrabin/tests_0624-131520de/LILACSMOKE_D_Ld2.f10_f10_mg37.I2000Ctsm50NwpSpAsRs.derecho_intel.clm-lilac.GC.06
24-131520de_int/CaseDocs/lnd_in' with '/glade/campaign/cgd/tss/ctsm_baselines/tmp-240620.n02.ctsm5.2.007/LILACSMOKE_D_Ld2.f10_f10_mg37.I2000Ctsm50NwpSpAsRs.der
echo_intel.clm-lilac/CaseDocs/lnd_in'
Differences in namelist 'clm_inparm':
  missing variable: 'fatmlndfrc'
  missing variable: 'hist_fincl2'
  missing variable: 'hist_fincl3'
  missing variable: 'hist_mfilt'
  missing variable: 'hist_mfilt(1)'
  missing variable: 'hist_ndens'
  missing variable: 'hist_nhtfrq'
  missing variable: 'hist_nhtfrq(1)'
  found extra variable: 'hillslope_fsat_equals_zero'
Missing baseline namelist '/glade/campaign/cgd/tss/ctsm_baselines/tmp-240620.n02.ctsm5.2.007/LILACSMOKE_D_Ld2.f10_f10_mg37.I2000Ctsm50NwpSpAsRs.derecho_intel.c
lm-lilac/CaseDocs/drv_flds_in'
Missing baseline namelist '/glade/campaign/cgd/tss/ctsm_baselines/tmp-240620.n02.ctsm5.2.007/LILACSMOKE_D_Ld2.f10_f10_mg37.I2000Ctsm50NwpSpAsRs.derecho_intel.c
lm-lilac/CaseDocs/nuopc.runseq'
Comparison failed between '/glade/derecho/scratch/samrabin/tests_0624-131520de/LILACSMOKE_D_Ld2.f10_f10_mg37.I2000Ctsm50NwpSpAsRs.derecho_intel.clm-lilac.GC.06
24-131520de_int/CaseDocs/drv_in' with '/glade/campaign/cgd/tss/ctsm_baselines/tmp-240620.n02.ctsm5.2.007/LILACSMOKE_D_Ld2.f10_f10_mg37.I2000Ctsm50NwpSpAsRs.der
echo_intel.clm-lilac/CaseDocs/drv_in'
Found extra namelist: debug_inparm
Found extra namelist: papi_inparm
Found extra namelist: prof_inparm

The only expected one of those was found extra variable: 'hillslope_fsat_equals_zero'. However, diffing lnd_in and lilac_in from the baseline vs. the new test shows none of those differences. I'm thus going to ignore this.

wwieder commented 3 months ago

Thanks @swensosc. I'm assuming you've tested that this works as intended? We'll discuss how to best merge this into our upcoming tags at this week's SE meeting?

samsrabin commented 3 months ago

@swensosc This is all ready. I'm going to just merge this and then open a separate PR here in CTSM to finish things off, so no more action needed from you. Thanks!