mksurfdata_jobscript_single.sh fails with the wrong message

slevis-lmwg commented 1 month ago

When mksurfdata_jobscript_single.sh fails and gives errors, it finishes with this deceptive message in the .o file: Successfully ran resolution

Presumably

the same will happen with mksurfdata_jobscript_multi.sh and
the problem is in this line if [ $? != 0 ]; then echo "Error running for namelist surfdata_0.9x1.25_hist_1700_78pfts_c240725.namelist"; exit -4; fi and, if so, the same problem likely applies to the similar line upstream from this one.

CTSM version you are using: ctsm5.2.015-6-gdc9996fa3

Does this bug cause significantly incorrect results in the model's science? No

Configurations affected: mksurfdata_esmf only

slevis-lmwg commented 1 month ago

I'd better clarify that mksurfdata_esmf works fine in general and that the above bug only applies when something goes wrong.

ekluzek commented 1 month ago

@slevis-lmwg says you can rely on the surfdata_*.log file being correct. It will show if an error happened.

slevis-lmwg commented 1 month ago

...at least I think that the .log file will give a "success" message only if it completes.

ESCOMP / CTSM