Don't allow SP, fates, or nofire tests to turn fire_emis on (and make sure our tests don't do this either)

ESCOMP / CTSM

Community Terrestrial Systems Model (includes the Community Land Model of CESM)

http://www.cesm.ucar.edu/models/cesm2.0/land/

Other

308 stars 312 forks source link

Don't allow SP, fates, or nofire tests to turn fire_emis on (and make sure our tests don't do this either) #2762

Open ekluzek opened 1 month ago

ekluzek commented 1 month ago

When -fire_emis is added to CLM_BLDNML_OPTS it should fail for configurations where fire-emissions won't be passed back. Right now that's SP mode, when nofire is turned on for BGC, or for FATES.

The FORTRAN code and build-namelist should disallow these options.

And we should make sure our testing don't turn on fire-emissions for these configurations.

Related issue: #2759

ekluzek commented 15 hours ago

In order to get this to work and have it tested in the FORTRAN code, I need to add unit testing around this. I've started doing that, but found out that for example shr_fire_emis_mod.F90 needs the full ESMF library. This is OK, since work was done to bring this into the unit-testing framework for submodules.

As such I need to work on #2640 before getting back to this.