ESCOMP / CTSM

Community Terrestrial Systems Model (includes the Community Land Model of CESM)
http://www.cesm.ucar.edu/models/cesm2.0/land/
Other
305 stars 308 forks source link

Add more system tests covering water tracers/isotopes #495

Open billsacks opened 6 years ago

billsacks commented 6 years ago

Very soon, I plan to add a one-timestep debug system test covering the tracer consistency check. Later, we should add more tests, covering at least the following (note that some of these things can be combined so that we only need a couple of tests total):

billsacks commented 5 years ago

Also want to cover some physics options that aren't covered by default, but which impact water fluxes / state updates - for example, groundwater irrigation.

billsacks commented 5 years ago

I'm changing the one-timestep test to one day, now that I have a mechanism in place to allow bypassing not-yet-tracerized code.

billsacks commented 5 years ago

I'm adding a LWISO test to ensure that turning on water isotopes doesn't change answers. However, I'm currently running into problems trying to run multiple time steps with enable_water_isotopes=.true.. I haven't dug into the problem in detail, but I have a feeling it's because we haven't fully tracerized the code yet, and while the test tracers are reset each time step, the true water tracers are not. So for now I'm using enable_water_tracer_consistency_checks=.true..

Once the true water isotopes are fully working, this LWISO test should probably be changed to use true water isotopes rather than test tracers, since that's a more appropriate / useful test (though it probably doesn't matter hugely).

Also, for now we need to use coldStart for this because we can't use initial conditions from a non-wiso case in a case with water isotopes; when we can eventually do that, we should change this test to non-coldStart and we can shorten it somewhat from its current 10 days (I'm making it 10 days in order to trigger more conditions than a 1 day test does when starting from cold start). Perhaps we should make it a 5-day, transient decStart test at that point.

billsacks commented 5 years ago

If we want to add nag tests, see #763 and #789 for caveats.