search

ESCOMP / FV3GFS_interface

CEMPS interface to FV3GFS
0 stars 2 forks source link

release/public-v1: adjust tasks per node and number of nodes for chgres pre-processing step; return to old version of buildlib used in UFS MR-Weather App release version 1.0 #12

Closed climbfuji closed 4 years ago

climbfuji commented 4 years ago

Note: this PR is currently for master, because git log shows that the branch I am working on is master with two commits on top if it

commit 0330e9c5ebc0cb40353f65d1097133e8e638bb18 (HEAD -> adjust_chgres_nodes_task_per_node, dom/adjust_chgres_nodes_task_per_node)
Author: Dom Heinzeller <climbfuji@ymail.com>
Date:   Tue Sep 22 06:01:42 2020 -0600

    cime_config/buildnml: adjust number of nodes and tasks per node for chgres pre-processing step

commit 10e9b7b6dac5d4b4dec42913b650f5bfd5a6c880
Author: uturuncoglu <turuncu@ucar.edu>
Date:   Wed Sep 9 21:59:26 2020 -0600

    return old version of buildlib used in UFS MR-Weather App release version 1.0

commit 69b96bea23214146fa80d24852ae7364c2ab3022 (origin/master, origin/HEAD, master)
Author: uturuncoglu <turuncu@ucar.edu>
Date:   Tue Sep 8 11:37:39 2020 -0600

    update test list to include Cheyenne with GNU and Orion

The existing branch release/public-v1 is several commits behind and in my opinion should be replaced with my proposed changes.

For a description of the problem and a summary of how this was solved, see https://github.com/ufs-community/ufs-mrweather-app/issues/190 https://github.com/ufs-community/ufs-mrweather-app/issues/200

uturuncoglu commented 4 years ago

@climbfuji I think you need to change your PR and point to ufs-release-v1.1 branch rather than pointing master. We specifically revert buildlib to the version that is used in the 1.0 release to solve the compile problem defined in https://github.com/ufs-community/ufs-mrweather-app/issues/169. I think we just need to need your mods for buildnml that I could push them directly to ufs-release-v1.1 branch. So, if it is okay for you, I could close this PR and make the required changes directly in the ufs-release-v1.1 branch. Let me know what do you think?

climbfuji commented 4 years ago

@uturuncoglu I changed the target branch to ufs-release-v1.1, and now it only shows one commit and change - the one in cime_config/buildnml, which is what we want.

uturuncoglu commented 4 years ago

Okay That is great.