ESCOMP / MOM_interface

CESM interface to MOM Ocean Model
5 stars 18 forks source link

Misc changes #154

Closed alperaltuntas closed 8 months ago

alperaltuntas commented 10 months ago

This PR changes answers. testing: aux_mom.derecho

alperaltuntas commented 10 months ago

TODO: We also need to update the standalone build script and templates. @mnlevy1981 ?

alperaltuntas commented 9 months ago

It looks like you have removed most, but not all, tests on the t061 grid. Do we need/want to be running tests on this grid? Besides this question the PR looks good to me.

There are two remaining t061 tests in aux_mom:

I think we should maintain the former test for as long as t061 is still an option. We may remove it if and when we decide to remove the t061 grid all together. Regarding the latter test, it corresponds to the wave-coupled compset. We haven't switched to the new grid for this compset yet, but I will update the test once we make that transition.

gustavo-marques commented 9 months ago

This PR will break our current diagnostics because the grid metrics are read from the static file. Before merging this PR, I suggest we discuss a plan going forward for supporting/providing the grid metrics for the 2/3 and 1/4 deg grids.

alperaltuntas commented 9 months ago

This PR will break our current diagnostics because the grid metrics are read from the static file. Before merging this PR, I suggest we discuss a plan going forward for supporting/providing the grid metrics for the 2/3 and 1/4 deg grids.

Can the diagnostics tools be reconfigured to read in the grid metrics from the ocean_hgrid (supergrid) file instead?