search

ESCOMP / MOSART

Model for Scale Adaptive River Transport, Mosart, part of the Community Earth System Model
http://www.cesm.ucar.edu/
Other
8 stars 27 forks source link

updates to nuopc cap #30

Closed mvertens closed 4 years ago

mvertens commented 4 years ago

This PR only effects the NUOPC cap and brings in updates that accompany CMEPS updates.

mvertens commented 4 years ago

@ekluzek - I have added the changes you requested and pushed back to github. Can this PR move ahead?

ekluzek commented 4 years ago

Yes. Did you run the one nuopc test or should I do that?

mvertens commented 4 years ago

@ekluzek - I am getting the same error with the correct tags. I will track this down. Thanks for doing this test.

mvertens commented 4 years ago

@ekluzek - I am getting the same error using the older code base. It seems to be dying in a pio call.

mvertens commented 4 years ago

@jedwards4b, @billsacks, @ekluzek - Backing up to pio1 fixed the problem - and the test ran successfully. This still had the modifications to the PR for ncdio_pio.F90.in. Its important to note that with mct as the coupling framework - the pio version out of the box is is pio1 NOT pio2. So this test will pass with pio1. I have verified that SMS_D_Vmct.f09_g17.I2000Clm50SpGs.cheyenne_intel crashes the same way as SMS_D_Vnuopc.f09_g17.I2000Clm50SpGs.cheyenne_intelwhen pio2 is used.

jedwards4b commented 4 years ago

@mvertens Can we open a new issue regarding the failing test? SMS_D.f09_g17.I2000Clm50SpGs.cheyenne_intel (with mct and nuopc and pio2) Can you tell if this a mosart issue or a CTSM one?

mvertens commented 4 years ago

@jedwards4b - this is a CTSM issue - not a MOSART issue. So this needs to go into the CTSM issues and I believe is a "critical issue". I will open it and assign it to you.

On Thu, Mar 12, 2020 at 6:45 AM jedwards4b notifications@github.com wrote:

@mvertens https://github.com/mvertens Can we open a new issue regarding the failing test? SMS_D.f09_g17.I2000Clm50SpGs.cheyenne_intel (with mct and nuopc and pio2) Can you tell if this a mosart issue or a CTSM one?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ESCOMP/MOSART/pull/30#issuecomment-598165637, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB4XCE5AS7GOKG6EC67BKEDRHDKPPANCNFSM4LFX2K2Q .

billsacks commented 4 years ago

@jedwards4b - I see you just pushed an additional fix to this branch. I'm going to start testing soon on this branch along with the corresponding nuopc_cap branches for rtm and ctsm. Do you plan to make any more changes to any of these branches?

jedwards4b commented 4 years ago

@billsacks I don't anticipate any further changes at this time. Thanks!