search

ESCOMP / MOSART

Model for Scale Adaptive River Transport, Mosart, part of the Community Earth System Model
http://www.cesm.ucar.edu/
Other
8 stars 27 forks source link

Add LILAC cap #32

Open billsacks opened 4 years ago

billsacks commented 4 years ago

At some point we need to bring this branch in to MOSART's main branch, so that we can run LILAC with MOSART. However, I'm not quite ready to do so, for a few reasons:

  1. I haven't reviewed these changes

  2. We don't have any tests in place that exercise this new cap

  3. From a very quick look, I noticed that the buildlib changes will need to be revised: we no longer use an environment variable to indicate that we're using LILAC, but instead use an xml variable defined in CTSM's config_component.xml. So we should query that XML variable, but do so in a way that, if the variable isn't found, then we proceed assuming that we're NOT using LILAC (so that this works in a case that includes MOSART without CTSM - e.g., with a data land model).

So for now I'm opening a PR so that we remember to bring this in at some point, but as far as I'm concerned, this can remain open for a while.

cc @mvertens @ekluzek

billsacks commented 4 years ago

See ESCOMP/CTSM@a1b038683 . These changes were needed to build / run lilac without mosart. Once we want to support mosart in lilac, we'll need to add some of those deleted lines back in buildlib, possibly conditionally. (I think the rest of the changes in that commit can remain as is, but see the commit log message for details.)