ESCOMP / MOSART

Model for Scale Adaptive River Transport, Mosart, part of the Community Earth System Model
http://www.cesm.ucar.edu/
Other
8 stars 27 forks source link

addition of flux area correction factors #40

Closed mvertens closed 3 years ago

mvertens commented 3 years ago

This PR adds area flux correction factors as is done in CPL7. Remove some debug writes of coupler fields. And remove state_getfldptr as it was unused.

Also sets the number of OpenMP threads according to the coupler namelist rather than env variables.

billsacks commented 3 years ago

Thanks @ekluzek . Note that the changes to threading are only in the nuopc cap, and threading with nuopc currently is not covered in our aux testing.

billsacks commented 3 years ago

I discussed this with @mvertens . She pointed out that you don't always want to do the area correction – such as for states. We came up with an interface to these routines that I like better to handle this:

billsacks commented 3 years ago

I have confirmed that my refactor did not change answers for the test SMS_D_Ld5_Vnuopc.f10_f10_mg37.I2000Clm50BgcCrop.cheyenne_intel.mosart-default, which I ran in the context of CESM's nuopc_dev branch. I will merge this shortly.