search

ESCOMP / MOSART

Model for Scale Adaptive River Transport, Mosart, part of the Community Earth System Model
http://www.cesm.ucar.edu/
Other
8 stars 27 forks source link

Remove setting of MOSART_MODE from buildnml #48

Closed ekluzek closed 2 years ago

ekluzek commented 2 years ago

In mosart1_0_44 I added an awkward change where MOSART_MODE gets set in buildnml.

Some comments on this are here:

https://github.com/ESCOMP/MOSART/pull/46#issuecomment-958116418

We need to decide on a better solution and bring that in when we can.

ekluzek commented 2 years ago

@billsacks notes there is likely an order dependence in the current operation which is bad. That could be removed by moving the change to buildlib, but it's still weird to have xml variables changed by buildlib.

billsacks commented 2 years ago

@ekluzek - I never addressed your initial question about having this in buildlib vs. buildnml. Since CLM_ACCELERATED_SPINUP is defined in env_run.xml, it feels wrong to have some dependence on it in buildlib, since then changes after building wouldn't be captured. So I think buildnml is better than buildlib, but both seem problematic.

ekluzek commented 2 years ago

Ahhh yes. One problem is actually that MOSART_MODE is in env_build, but CLM_ACCELERATED_SPINUP is in env_run. So neither way is technically correct. But, you could argue that since MOSART_MODE is env_build it should be in buildlib. And I suppose we could move CLM_ACCELERATED_SPINUP in env_build as well. But, I still agree that neither way is good here. I do think putting it in env_build removes the potential order dependence issue that you brought up though.

We'll talk more about this tomorrow. I hope we can come up with something that feels better all around.