search

ESCOMP / MOSART

Model for Scale Adaptive River Transport, Mosart, part of the Community Earth System Model
http://www.cesm.ucar.edu/
Other
8 stars 27 forks source link

Jedwards/asyncio #55

Closed jedwards4b closed 2 years ago

jedwards4b commented 2 years ago

Currently mosart initializes and try's to use IO in the advertise phase, but asyncio requires that this is not done until the realize phase. This PR splits the mosart initialization so that the namelist is still read in the advertise phase but IO waits until the realize phase. Tested with cesm prealpha tests on cheyenne, a modification was also required in the mct driver to handle the new initialize subroutine.

jedwards4b commented 2 years ago

I imagine this will need to happen in RTM and CTSM as well right? And mizuRoute for that matter. No - I only found a couple of components that did the IO initialization this early - mosart and cice.

I've cleaned up and removed unused variables.

jedwards4b commented 2 years ago

@ekluzek I don't believe that there is a test of the mizuRoute in the cesm test suite. The key is to make sure no IO is performed until the realize phase of initializaton.

ekluzek commented 2 years ago

@jedwards4b I took a look at the mizuRoute code, and I didn't see any IO before the realize phase. So it's probably OK, but we might find out differently when we add more testing with mizuRoute in the system.