search

ESCOMP / MOSART

Model for Scale Adaptive River Transport, Mosart, part of the Community Earth System Model
http://www.cesm.ucar.edu/
Other
9 stars 27 forks source link

Stop running 0th timestep #67

Closed olyson closed 2 weeks ago

olyson commented 1 year ago

Changes needed to stop running 0th timestep. See CTSM issue https://github.com/ESCOMP/CTSM/issues/925 and PR https://github.com/ESCOMP/CTSM/pull/2084

slevis-lmwg commented 2 weeks ago

@olyson I assigned you because you worked on this, not because i need something from you at this time.

slevis-lmwg commented 2 weeks ago

@olyson I have @jedwards4b approval here, but mosart's timemanager changed since you worked on this, such that the line is_first_step = (nstep == 0) is not there to remove anymore. From a quick look, I don't see other cases of nstep that need modification, but could you confirm?

olyson commented 2 weeks ago

I guess the function itself (is_first_step) has been removed since this PR was first issued, so that seems ok. I don't see any other instances of nstep that need modification.

slevis-lmwg commented 2 weeks ago

derecho OK ./run_sys_tests -s mosart -c mosart1.1.04-ctsm5.3.009 -g mosart1.1.05-ctsm5.3.011

izumi OK ./run_sys_tests -s mosart -c mosart1.1.04_ctsm5.3.009 -g mosart1.1.05_ctsm5.3.011