Omit dummy paths "unknown*" and "same_as*" in input_data_list

[alperaltuntas]

Description of changes:

With this change, build-namelist omits all dummy paths beginning with "unknown" and "same_as" in pop.input_data_list. No changes in pop namelist.

Testing:

Test case/suite: aux_pop.cheyenne_intel Test status: bit for bit

Fixes #23

User interface (namelist or namelist defaults) changes? no

[mvertens]

CIME was trying to look for these files on glade - and special logic needed to be introduced into CIME to ignore those files. We do not want to have CIME know about namelists that are component specific. We have a temporary work around in CIME but the right solution is to have POP not list these files in its input.datalist. So there is definitely a change in this PR for how POP interacts with CIME.

On Tue, Mar 17, 2020 at 11:19 AM Michael Levy notifications@github.com wrote:

@mnlevy1981 requested changes on this pull request.

I'm a little confused about how this addresses #23 https://github.com/ESCOMP/POP2-CESM/issues/23: I think this is a great way to to generalize the logic that's already in build-namelist so we don't need to add a new if (($var eq '...') and ($pathname eq 'unknown...')) block every time a variable that might not require a file is added, but the issue ticket says

Special logic should not be in cime to ignore these (as was the case before)

and nothing in this PR seems to change how POP interacts with CIME.

@mvertens https://github.com/mvertens what error were you seeing when you tried to update CIME to remove this logic? Was there just a one-off variable that slipped into pop.input_data_list?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ESCOMP/POP2-CESM/pull/24#pullrequestreview-376245131, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB4XCE2B3IPDVCZLU43BUHTRH6WLPANCNFSM4LMV3YJQ .

[mnlevy1981]

CIME was trying to look for these files on glade - and special logic needed to be introduced into CIME to ignore those files. We do not want to have CIME know about namelists that are component specific. We have a temporary work around in CIME but the right solution is to have POP not list these files in its input.datalist. So there is definitely a change in this PR for how POP interacts with CIME.

Which files, though? If you look at the old code, there were checks in place to prevent bottom_cell_file, tidal_energy_file, niw_energy_file, init_iage_init_file, init_ecosys_init_file, init_abio_dic_dic14_init_file, abio_dic_dic14_restfile_fallback, and ciso_init_ecosys_init_file from ending up in the input data list -- what variable triggered the error in your case?

I'm just confused about (a) what logic in CIME you are trying to remove, and (b) why the error is cropping up now

[klindsay28]

@mnlevy1981, see https://github.com/ESMCI/cime/pull/3451

I'm assuming #23, which this should address, is in response to that.

[alperaltuntas]

@mnlevy1981, prior to this PR, build-namelist was not exhaustive when it comes to omitting dummy file names. Some examples that build-namelist would NOT omit in pop.input_data_list:

tidal_vars_file_polz = unknown_tidal_vars_file_polz
ebm_param_filename = unknown_ebm_param_filename
init_cfc_init_file = same_as_TS
init_sf6_init_file = same_as_TS

This PR makes sure that no file path beginning with "same_as" or "unknown" gets written to input_data_list".