search

ESCOMP / POP2-CESM

Parallel Ocean Program (POP2) in CESM
http://www.cesm.ucar.edu/models/cesm2/ocean/
4 stars 24 forks source link

add support for threading in cmeps, add SourceMods in bld #51

Closed jedwards4b closed 3 years ago

jedwards4b commented 3 years ago

Description of changes:

Add support for cmeps based threading

Testing:

Test case/suite: SMS_Vnuopc.f19_g17.B1850 Test status: bit for bit

Fixes [POP2 Github issue #]

User interface (namelist or namelist defaults) changes?

alperaltuntas commented 3 years ago

@jedwards4b The following test fails at run phase when running with the latest CESM nuopc_dev: ERI_Vnuopc.T62_g17.G.cheyenne_intel

jedwards4b commented 3 years ago

@alperaltuntas can you point to your test case?? this test doesn't involve threading so I'm not sure what it would have to do with this PR.

jedwards4b commented 3 years ago

@alperaltuntas this ran in my sandbox with no issues /glade/scratch/jedwards/ERI_Vnuopc.T62_g17.G.cheyenne_intel.20210408_155153_ploucj PASS ERI_Vnuopc.T62_g17.G.cheyenne_intel CREATE_NEWCASE PASS ERI_Vnuopc.T62_g17.G.cheyenne_intel XML PASS ERI_Vnuopc.T62_g17.G.cheyenne_intel SETUP PASS ERI_Vnuopc.T62_g17.G.cheyenne_intel SHAREDLIB_BUILD time=209 PASS ERI_Vnuopc.T62_g17.G.cheyenne_intel MODEL_BUILD time=135 PASS ERI_Vnuopc.T62_g17.G.cheyenne_intel SUBMIT PASS ERI_Vnuopc.T62_g17.G.cheyenne_intel RUN time=335 PASS ERI_Vnuopc.T62_g17.G.cheyenne_intel COMPARE_base_hybrid PASS ERI_Vnuopc.T62_g17.G.cheyenne_intel COMPARE_base_rest PASS ERI_Vnuopc.T62_g17.G.cheyenne_intel MEMLEAK insuffiencient data for memleak test PASS ERI_Vnuopc.T62_g17.G.cheyenne_intel SHORT_TERM_ARCHIVER

mvertens commented 3 years ago

@jedwards4b - can you please point Alper to your externals - I think that might be the issue.

On Thu, Apr 8, 2021 at 4:07 PM jedwards4b @.***> wrote:

@alperaltuntas https://github.com/alperaltuntas this ran in my sandbox with no issues

/glade/scratch/jedwards/ERI_Vnuopc.T62_g17.G.cheyenne_intel.20210408_155153_ploucj PASS ERI_Vnuopc.T62_g17.G.cheyenne_intel CREATE_NEWCASE PASS ERI_Vnuopc.T62_g17.G.cheyenne_intel XML PASS ERI_Vnuopc.T62_g17.G.cheyenne_intel SETUP PASS ERI_Vnuopc.T62_g17.G.cheyenne_intel SHAREDLIB_BUILD time=209 PASS ERI_Vnuopc.T62_g17.G.cheyenne_intel MODEL_BUILD time=135 PASS ERI_Vnuopc.T62_g17.G.cheyenne_intel SUBMIT PASS ERI_Vnuopc.T62_g17.G.cheyenne_intel RUN time=335 PASS ERI_Vnuopc.T62_g17.G.cheyenne_intel COMPARE_base_hybrid PASS ERI_Vnuopc.T62_g17.G.cheyenne_intel COMPARE_base_rest PASS ERI_Vnuopc.T62_g17.G.cheyenne_intel MEMLEAK insuffiencient data for memleak test PASS ERI_Vnuopc.T62_g17.G.cheyenne_intel SHORT_TERM_ARCHIVER

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ESCOMP/POP2-CESM/pull/51#issuecomment-816261434, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB4XCE77OJ2SD34FJMDXXULTHYSILANCNFSM42M45A2Q .

-- Mariana Vertenstein CESM Software Engineering Group Head National Center for Atmospheric Research Boulder, Colorado Office 303-497-1349 Email: @.***

jedwards4b commented 3 years ago

cime, cmeps and cdeps and cice are all on master. pop is this PR

alperaltuntas commented 3 years ago

I was using the latest CESM nuopc_dev, but I'll try rerunning with master cime, cmeps and cdeps. Here is the failed test: /glade/scratch/altuntas/ERI_Vnuopc.T62_g17.G.cheyenne_intel.C.20210408_141329_p1ydy7.ref1

alperaltuntas commented 3 years ago

With the latest master branches of cime, cmeps and cdeps, the test now passes. I'll run a few more tests and merge this PR. I'll then create a new tag.