search

ESCOMP / POP2-CESM

Parallel Ocean Program (POP2) in CESM
http://www.cesm.ucar.edu/models/cesm2/ocean/
4 stars 24 forks source link

clean up nuopc cap, reduce output to cesm.log file #67

Closed jedwards4b closed 2 years ago

jedwards4b commented 2 years ago

Description of changes:

Cleanup output to stdout. This PR is intended to reduce the amount of data written to the cesm.log in production mode. When DEBUG is defined all output is retained.

Testing:

Tested by hand using ERS_D.f19_g17.B1850.cheyenne_intel.allactive-defaultio Test case/suite: Test status: bit for bit

Fixes [POP2 Github issue #]

User interface (namelist or namelist defaults) changes? NONE

jedwards4b commented 2 years ago

It should set the same value. If not we have problems anyway. No need to have two of the same variable.

On Thu, Mar 24, 2022, 08:42 Keith Lindsay @.***> wrote:

@.**** commented on this pull request.

In drivers/nuopc/ocn_comp_nuopc.F90 https://github.com/ESCOMP/POP2-CESM/pull/67#discussion_r834386078:

@@ -220,13 +219,13 @@ subroutine InitializeAdvertise(gcomp, importState, exportState, clock, rc) call ESMF_GridCompGet(gcomp, vm=vm, rc=rc) if (ChkErr(rc,LINE,u_FILE_u)) return

  • call ESMF_VMGet(vm, mpiCommunicator=lmpicom, localPet=iam, rc=rc)
  • call ESMF_VMGet(vm, mpiCommunicator=lmpicom, localPet=my_task, rc=rc)

This change looks suspicious to me. It looks like it is using the ESMF API to set my_task, which is a module variable in communicate.F90 and is set there (via a setting of POP_myTask in POP_CommMod.F90). The previous code didn't modify POP's my_task variable.

— Reply to this email directly, view it on GitHub https://github.com/ESCOMP/POP2-CESM/pull/67#pullrequestreview-920382596, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABOXUGCHMQR77SUFBECC4X3VBR5MHANCNFSM5RCIKKSA . You are receiving this because you authored the thread.Message ID: @.***>