Closed mnlevy1981 closed 1 year ago
I still need to update Externals_POP.cfg
once there is a MARBL tag.
Should we run 4p2z by default? I either need to add a 4p2z test to aux_pop_MARBL
or make the default 4p2z and add a 3p1z test to aux_pop_MARBL
depending on the answer to that question.
Testing results: I ran aux_pop_MARBL
on cheyenne (with both intel and gnu). All tests fail NLCOMP
due to additional variables that were added to marbl_in
in recent MARBL updates (we are jumping from marbl0.40.3
to marbl0.43.0
, so there's a lot to catch up on). Further, all tests are failing BASELINE
because those recent MARBL commits also added some new diagnostics for FEISTY. There are two tests that are actually changing answers, and failing the BASELINE
due to RMS differences detected by cprnc
:
ecosys_add_cocco
: One of the MARBL changes is to cap picpoc
at 1.0, which I believe only affects explicit calcifiers. Since the default 3p1z configuration has an implicit calcifier, the majority of tests do not run through that portion of the code. Coccolithophores are an explicit calcifier, though, so the 4p1z configuration in the add_cocco
test does compute / use this picpoc
term.ecosys_spectra_pfts
: One of the MARBL changes was an update to how zoo_loss
is routed; it was brought in as a recent update to SPECTRA. Not only does that specific code modification change answers, but I also provided a more recent SPECTRA-fied version of user_nl_marbl
for this test to keep the test in line with how the code has most recently been run.
Description of changes:
Update MARBL to use latest version (after https://github.com/marbl-ecosys/MARBL/pull/423 is accepted / merged / tagged)
Testing:
Test case/suite: none yet; will run
aux_pop
andaux_pop_MARBL
and comment on results below Test status: [bit for bit, roundoff, climate changing]Fixes [POP2 Github issue #] No tagged issues, though there are some MARBL-related issues that might be easy to fix that could be included
User interface (namelist or namelist defaults) changes?
latest+4p2z
is a new valid value forOCN_BGC_CONFIG